Skip to content

feat(docs/testing): document manual discovery locations #66

feat(docs/testing): document manual discovery locations

feat(docs/testing): document manual discovery locations #66

Triggered via pull request July 30, 2025 19:29
Status Failure
Total duration 40s
Artifacts

coding-conventions.yml

on: pull_request
Run style check
32s
Run style check
Fit to window
Zoom out
Zoom in

Annotations

8 errors, 10 warnings, and 7 notices
Run style check
Process completed with exit code 1.
analysis/override-attribute: src/Web/Blog/BlogIndexer.php#L23
Missing `#[Override]` attribute on overriding method `App\Web\Blog\BlogIndexer::index`. The `#[Override]` attribute clarifies intent and prevents accidental signature mismatches. Help: Add `#[Override]` attribute to method declaration.
analysis/override-attribute: src/Highlight/Patterns/TempestViewCommentPattern.php#L18
Missing `#[Override]` attribute on overriding method `App\Highlight\Patterns\TempestViewCommentPattern::getTokenType`. The `#[Override]` attribute clarifies intent and prevents accidental signature mismatches. Help: Add `#[Override]` attribute to method declaration.
analysis/override-attribute: src/Web/CommandPalette/CommandIndexer.php#L14
Missing `#[Override]` attribute on overriding method `App\Web\CommandPalette\CommandIndexer::index`. The `#[Override]` attribute clarifies intent and prevents accidental signature mismatches. Help: Add `#[Override]` attribute to method declaration.
analysis/override-attribute: src/Web/Community/CommunityPostIndexer.php#L16
Missing `#[Override]` attribute on overriding method `App\Web\Community\CommunityPostIndexer::index`. The `#[Override]` attribute clarifies intent and prevents accidental signature mismatches. Help: Add `#[Override]` attribute to method declaration.
analysis/override-attribute: src/Web/Documentation/DocumentationIndexer.php#L35
Missing `#[Override]` attribute on overriding method `App\Web\Documentation\DocumentationIndexer::index`. The `#[Override]` attribute clarifies intent and prevents accidental signature mismatches. Help: Add `#[Override]` attribute to method declaration.
analysis/override-attribute: src/Web/CommandPalette/IndexerDiscovery.php#L25
Missing `#[Override]` attribute on overriding method `App\Web\CommandPalette\IndexerDiscovery::apply`. The `#[Override]` attribute clarifies intent and prevents accidental signature mismatches. Help: Add `#[Override]` attribute to method declaration.
analysis/override-attribute: src/Web/CommandPalette/IndexerDiscovery.php#L18
Missing `#[Override]` attribute on overriding method `App\Web\CommandPalette\IndexerDiscovery::discover`. The `#[Override]` attribute clarifies intent and prevents accidental signature mismatches. Help: Add `#[Override]` attribute to method declaration.
best-practices/literal-named-argument: src/Markdown/Alerts/AlertBlockRenderer.php#L41
Literal argument `'<x-icon :name="$name" class="alert-icon" />'` should be passed as a named argument for clarity. Using named arguments for literals, especially booleans, numbers, or `null`, makes the function/method call more self-documenting by clarifying the purpose of the value. Help: Consider changing the call to `function_name(literal: '<x-icon :name="$name" class="alert-icon" />')` instead of `function_name('<x-icon :name="$name" class="alert-icon" />')`.
best-practices/literal-named-argument: src/Highlight/Injections/StrongInjection.php#L26
Literal argument `'</span>'` should be passed as a named argument for clarity. Using named arguments for literals, especially booleans, numbers, or `null`, makes the function/method call more self-documenting by clarifying the purpose of the value. Help: Consider changing the call to `function_name(literal: '</span>')` instead of `function_name('</span>')`.
best-practices/literal-named-argument: src/Highlight/Injections/StrongInjection.php#L24
Literal argument `'<span class="hl-console-strong">'` should be passed as a named argument for clarity. Using named arguments for literals, especially booleans, numbers, or `null`, makes the function/method call more self-documenting by clarifying the purpose of the value. Help: Consider changing the call to `function_name(literal: '<span class="hl-console-strong">')` instead of `function_name('<span class="hl-console-strong">')`.
best-practices/literal-named-argument: src/Highlight/Injections/StrongInjection.php#L23
Literal argument `'%s%s%s'` should be passed as a named argument for clarity. Using named arguments for literals, especially booleans, numbers, or `null`, makes the function/method call more self-documenting by clarifying the purpose of the value. Help: Consider changing the call to `function_name(literal: '%s%s%s')` instead of `function_name('%s%s%s')`.
best-practices/literal-named-argument: src/Highlight/Injections/QuestionInjection.php#L26
Literal argument `'</span>'` should be passed as a named argument for clarity. Using named arguments for literals, especially booleans, numbers, or `null`, makes the function/method call more self-documenting by clarifying the purpose of the value. Help: Consider changing the call to `function_name(literal: '</span>')` instead of `function_name('</span>')`.
best-practices/literal-named-argument: src/Highlight/Injections/QuestionInjection.php#L24
Literal argument `'<span class="hl-console-question">'` should be passed as a named argument for clarity. Using named arguments for literals, especially booleans, numbers, or `null`, makes the function/method call more self-documenting by clarifying the purpose of the value. Help: Consider changing the call to `function_name(literal: '<span class="hl-console-question">')` instead of `function_name('<span class="hl-console-question">')`.
best-practices/literal-named-argument: src/Highlight/Injections/QuestionInjection.php#L23
Literal argument `'%s%s%s'` should be passed as a named argument for clarity. Using named arguments for literals, especially booleans, numbers, or `null`, makes the function/method call more self-documenting by clarifying the purpose of the value. Help: Consider changing the call to `function_name(literal: '%s%s%s')` instead of `function_name('%s%s%s')`.
best-practices/literal-named-argument: src/Markdown/HandleParser.php#L17
Literal argument `'{(twitter|x|bluesky|bsky|gh|github):(.+?)(?:,(.+?))?}'` should be passed as a named argument for clarity. Using named arguments for literals, especially booleans, numbers, or `null`, makes the function/method call more self-documenting by clarifying the purpose of the value. Help: Consider changing the call to `function_name(literal: '{(twitter|x|bluesky|bsky|gh|github):(.+?)(?:,(.+?))?}')` instead of `function_name('{(twitter|x|bluesky|bsky|gh|github):(.+?)(?:,(.+?))?}')`.
best-practices/literal-named-argument: src/Markdown/MarkdownPost.php#L18
Literal argument `'/<h3.*>.*<a.*href="(?<h3uri>.*?)".*?<\/span>(?<h3title>.*)<\/a><\/h3>/'` should be passed as a named argument for clarity. Using named arguments for literals, especially booleans, numbers, or `null`, makes the function/method call more self-documenting by clarifying the purpose of the value. Help: Consider changing the call to `function_name(literal: '/<h3.*>.*<a.*href="(?<h3uri>.*?)".*?<\/span>(?<h3title>.*)<\/a><\/h3>/')` instead of `function_name('/<h3.*>.*<a.*href="(?<h3uri>.*?)".*?<\/span>(?<h3title>.*)<\/a><\/h3>/')`.
best-practices/literal-named-argument: src/Markdown/MarkdownPost.php#L17
Literal argument `'/<h2.*>.*<a.*href="(?<uri>.*?)".*?<\/span>(?<title>.*)<\/a><\/h2>/'` should be passed as a named argument for clarity. Using named arguments for literals, especially booleans, numbers, or `null`, makes the function/method call more self-documenting by clarifying the purpose of the value. Help: Consider changing the call to `function_name(literal: '/<h2.*>.*<a.*href="(?<uri>.*?)".*?<\/span>(?<title>.*)<\/a><\/h2>/')` instead of `function_name('/<h2.*>.*<a.*href="(?<uri>.*?)".*?<\/span>(?<title>.*)<\/a><\/h2>/')`.
consistency/string-interpolation-braces: src/Markdown/TempestPackageParser.php#L44
Unbraced variable in string interpolation Using curly braces around variables in interpolated strings improves readability and prevents potential parsing issues. Help: Wrap the variable in curly braces, e.g., `{$variable}`.
best-practices/no-unused-parameter: src/Web/Analytics/StatsController.php#L47
Parameter `$b` is never used. This parameter is declared but not used within the arrow function. Help: Consider prefixing the parameter with an underscore (`_`) to indicate that it is intentionally unused, or remove it if it is not needed.
best-practices/no-unused-parameter: src/Web/Analytics/StatsController.php#L19
Parameter `$clock` is never used. This parameter is declared but not used within the method. Help: Consider prefixing the parameter with an underscore (`_`) to indicate that it is intentionally unused, or remove it if it is not needed.
consistency/string-interpolation-braces: src/Markdown/HandleParser.php#L38
Unbraced variable in string interpolation Using curly braces around variables in interpolated strings improves readability and prevents potential parsing issues. Help: Wrap the variable in curly braces, e.g., `{$variable}`.
consistency/string-interpolation-braces: src/Markdown/HandleParser.php#L37
Unbraced variable in string interpolation Using curly braces around variables in interpolated strings improves readability and prevents potential parsing issues. Help: Wrap the variable in curly braces, e.g., `{$variable}`.
consistency/string-interpolation-braces: src/Markdown/HandleParser.php#L36
Unbraced variable in string interpolation Using curly braces around variables in interpolated strings improves readability and prevents potential parsing issues. Help: Wrap the variable in curly braces, e.g., `{$variable}`.
consistency/string-interpolation-braces: src/Markdown/HandleParser.php#L35
Unbraced variable in string interpolation Using curly braces around variables in interpolated strings improves readability and prevents potential parsing issues. Help: Wrap the variable in curly braces, e.g., `{$variable}`.