Skip to content
Coding Conventions

fix(view): allow specifying dynamic icon names #1620

Sign in to view logs

fix(view): allow specifying dynamic icon names

fix(view): allow specifying dynamic icon names #1620

Triggered via pull request April 22, 2025 17:43
@innocenziinnocenzi
synchronize #1163
runtime-icon-component
Status Failure
Total duration 56s
Artifacts –

coding-conventions.yml

on: pull_request
Run style check
27s
Run style check
Run static analysis: PHPStan
50s
Run static analysis: PHPStan
Fit to window
Zoom out
Zoom in

Annotations

3 errors
Run style check
Process completed with exit code 1.
Run static analysis: PHPStan
Process completed with exit code 1.
Run static analysis: PHPStan: src/Tempest/View/src/Components/Icon.php#L53
Method Tempest\View\Components\Icon::render() never returns null so it can be removed from the return type.