Skip to content
Coding Conventions

refactor(http): improve session management and CSRF protection #3044

Sign in to view logs

refactor(http): improve session management and CSRF protection

refactor(http): improve session management and CSRF protection #3044

Triggered via pull request December 21, 2025 20:09
@innocenziinnocenzi
opened #1829
refactor/session
Status Failure
Total duration 51s
Artifacts –

coding-conventions.yml

on: pull_request
Run style check
41s
Run style check
Run static analysis: PHPStan
45s
Run static analysis: PHPStan
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 4 warnings
Run style check
Process completed with exit code 1.
Run static analysis: PHPStan
Process completed with exit code 1.
Run static analysis: PHPStan: tests/Integration/Http/RedisSessionTest.php#L50
Parameter $config of class Tempest\Http\Session\Managers\RedisSessionManager constructor expects Tempest\Http\Session\Config\RedisSessionConfig, Tempest\Http\Session\SessionConfig given.
Run static analysis: PHPStan: tests/Integration/Http/RedisSessionTest.php#L32
Get hook for property Tests\Tempest\Integration\Http\RedisSessionTest::$manager should return Tempest\Http\Session\Managers\RedisSessionManager but returns Tempest\Http\Session\SessionManager.
Run static analysis: PHPStan: tests/Integration/Http/FileSessionTest.php#L33
Get hook for property Tests\Tempest\Integration\Http\FileSessionTest::$manager should return Tempest\Http\Session\Managers\FileSessionManager but returns Tempest\Http\Session\SessionManager.
Run static analysis: PHPStan: tests/Integration/Http/DatabaseSessionTest.php#L46
Class Tempest\Http\Session\Managers\DatabaseSessionManager constructor invoked with 3 parameters, 2 required.
Run static analysis: PHPStan: tests/Integration/Http/DatabaseSessionTest.php#L34
Get hook for property Tests\Tempest\Integration\Http\DatabaseSessionTest::$manager should return Tempest\Http\Session\Managers\DatabaseSessionManager but returns Tempest\Http\Session\SessionManager.
no-redundant-use: tests/Integration/Http/Responses/GenericResponseTest.php#L10
Unused import: `Session`. Help: Remove the entire `use` statement.
no-redundant-use: packages/auth/src/Authentication/AuthenticatorInitializer.php#L7
Unused import: `AuthConfig`. Help: Remove the entire `use` statement.
no-redundant-use: packages/http/src/IsResponse.php#L11
Unused import: `Session`. Help: Remove the entire `use` statement.
no-ini-set: packages/core/src/FrameworkKernel.php#L251
ini_set should not be used. Framework level constant or dedicated configuration are preferred. Help: Use a framework specific configuration instead of `ini_set`.