feat(http): improve context for failed http requests (#1484)

Author: brendt

packages/core/src/LogExceptionProcessor.php

@@ -13,6 +13,7 @@ final class LogExceptionProcessor implements ExceptionProcessor
     public function process(Throwable $throwable): Throwable
     {
         $items = [
+            'class' => $throwable::class,
             'exception' => $throwable->getMessage(),
             'context' => ($throwable instanceof HasContext)
                 ? $throwable->context()

packages/http/src/HttpRequestFailed.php

@@ -4,24 +4,28 @@
 
 use Exception;
 use Tempest\Core\HasContext;
+use Throwable;
 
 /**
  * Represents an HTTP exception.
  */
 final class HttpRequestFailed extends Exception implements HasContext
 {
     public function __construct(
+        public readonly Request $request,
         public readonly Status $status,
         ?string $message = null,
         public readonly ?Response $cause = null,
-        ?\Throwable $previous = null,
+        ?Throwable $previous = null,
     ) {
         parent::__construct($message ?: '', $status->value, $previous);
     }
 
     public function context(): array
     {
         return [
+            'request_uri' => $this->request->uri,
+            'request_method' => $this->request->method->value,
             'status' => $this->status->value,
             'message' => $this->message,
             'cause' => $this->cause,

packages/icon/src/Icon.php

@@ -4,7 +4,9 @@
 
 use Exception;
 use Tempest\EventBus\EventBus;
+use Tempest\Http\GenericRequest;
 use Tempest\Http\HttpRequestFailed;
+use Tempest\Http\Method;
 use Tempest\Http\Status;
 use Tempest\HttpClient\HttpClient;
 use Tempest\Support\Str;
@@ -61,7 +63,11 @@ private function fetchSvg(string $collection, string $icon): ?string
             $response = $this->http->get($url);
 
             if ($response->status !== Status::OK) {
-                throw new HttpRequestFailed($response->status, cause: $response);
+                throw new HttpRequestFailed(
+                    request: new GenericRequest(Method::GET, $url),
+                    status: $response->status,
+                    cause: $response,
+                );
             }
 
             $this->eventBus?->dispatch(new IconDownloaded(

packages/router/src/HandleRouteExceptionMiddleware.php

@@ -26,6 +26,7 @@ public function __invoke(Request $request, HttpMiddlewareCallable $next): Respon
 
             if ($response->status->isServerError() || $response->status->isClientError()) {
                 throw new HttpRequestFailed(
+                    request: $request,
                     status: $response->status,
                     cause: $response,
                 );

tests/Integration/Http/HttpExceptionHandlerTest.php

@@ -9,18 +9,20 @@
 use Tempest\Core\AppConfig;
 use Tempest\Core\FrameworkKernel;
 use Tempest\Core\Kernel;
+use Tempest\Http\GenericRequest;
 use Tempest\Http\HttpRequestFailed;
+use Tempest\Http\Method;
 use Tempest\Http\Response;
 use Tempest\Http\Responses\Redirect;
 use Tempest\Http\Session\CsrfTokenDidNotMatch;
 use Tempest\Http\Status;
 use Tempest\Router\Exceptions\HttpExceptionHandler;
-use Tempest\Router\Exceptions\RouteBindingFailed;
 use Tempest\Router\ResponseSender;
 use Tests\Tempest\Integration\FrameworkIntegrationTestCase;
 use Tests\Tempest\Integration\Http\Fixtures\ExceptionThatConvertsToRedirectResponse;
 use Tests\Tempest\Integration\Http\Fixtures\ExceptionWithContext;
 use Tests\Tempest\Integration\Http\Fixtures\NullExceptionProcessor;
+use Throwable;
 
 final class HttpExceptionHandlerTest extends FrameworkIntegrationTestCase
 {
@@ -125,7 +127,7 @@ public function test_exception_handler_returns_same_code_as_http_exception(Statu
     {
         $this->callExceptionHandler(function () use ($status): void {
             $handler = $this->container->get(HttpExceptionHandler::class);
-            $handler->handle(new HttpRequestFailed($status));
+            $handler->handle(new HttpRequestFailed(new GenericRequest(Method::GET, '/test'), $status));
         });
 
         $this->assertSame($status, $this->response->status);
@@ -164,7 +166,7 @@ private function callExceptionHandler(Closure $callback): void
     {
         try {
             $callback();
-        } catch (\Throwable $throwable) {
+        } catch (Throwable $throwable) {
             $this->assertSame('Shutdown.', $throwable->getMessage());
         }
     }