feat(view): support single-quote attributes (#1678)

brendt · web-flow · commit 071993ab2b29 · 2025-11-05T09:17:14.000+01:00
diff --git a/packages/view/src/Parser/TempestViewLexer.php b/packages/view/src/Parser/TempestViewLexer.php
@@ -131,8 +131,12 @@ private function lexTag(): array
                 );
 
                 if ($hasValue) {
-                    $attributeValue = $this->consumeIncluding('"');
-                    $attributeValue .= $this->consumeIncluding('"');
+                    $quote = $this->seek() === '\''
+                        ? '\''
+                        : '"';
+
+                    $attributeValue = $this->consumeIncluding($quote);
+                    $attributeValue .= $this->consumeIncluding($quote);
 
                     $tokens[] = new Token(
                         content: $attributeValue,
diff --git a/packages/view/src/Parser/Token.php b/packages/view/src/Parser/Token.php
@@ -142,6 +142,10 @@ private function attributeName(string $name): string
 
     private function attributeValue(string $value): string
     {
-        return str($value)->afterFirst('"')->beforeLast('"')->toString();
+        $value = str($value);
+
+        $quote = $value->startsWith('"') ? '"' : "'";
+
+        return str($value)->afterFirst($quote)->beforeLast($quote)->toString();
     }
 }
diff --git a/packages/view/tests/TempestViewLexerTest.php b/packages/view/tests/TempestViewLexerTest.php
@@ -346,6 +346,26 @@ public function test_xml(): void
         );
     }
 
+    public function test_single_quote_attributes(): void
+    {
+        $html = <<<HTML
+        <div class='hello'></div>
+        HTML;
+
+        $tokens = new TempestViewLexer($html)->lex();
+
+        $this->assertTokens(
+            expected: [
+                new Token('<div', TokenType::OPEN_TAG_START),
+                new Token(' class=', TokenType::ATTRIBUTE_NAME),
+                new Token('\'hello\'', TokenType::ATTRIBUTE_VALUE),
+                new Token('>', TokenType::OPEN_TAG_END),
+                new Token('</div>', TokenType::CLOSING_TAG),
+            ],
+            actual: $tokens,
+        );
+    }
+
     private function assertTokens(array $expected, TokenCollection $actual): void
     {
         $this->assertCount(count($expected), $actual);
diff --git a/tests/Integration/View/TempestViewRendererTest.php b/tests/Integration/View/TempestViewRendererTest.php
@@ -847,4 +847,13 @@ public function test_parse_rss_feed(): void
         </feed>
         RSS, $parsed);
     }
+
+    public function test_attributes_with_single_quotes(): void
+    {
+        $html = $this->render(<<<'HTML'
+        <div class='hello'></div>
+        HTML);
+
+        $this->assertSnippetsMatch('<div class="hello"></div>', $html);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -142,6 +142,10 @@ private function attributeName(string $name): string`
`142`	`142`
`143`	`143`	`private function attributeValue(string $value): string`
`144`	`144`	`{`
`145`		`- return str($value)->afterFirst('"')->beforeLast('"')->toString();`
	`145`	`+ $value = str($value);`
	`146`	`+`
	`147`	`+ $quote = $value->startsWith('"') ? '"' : "'";`
	`148`	`+`
	`149`	`+ return str($value)->afterFirst($quote)->beforeLast($quote)->toString();`
`146`	`150`	`}`
`147`	`151`	`}`
Original file line number	Diff line number	Diff line change
`@@ -847,4 +847,13 @@ public function test_parse_rss_feed(): void`
`847`	`847`	`</feed>`
`848`	`848`	`RSS, $parsed);`
`849`	`849`	`}`
	`850`	`+`
	`851`	`+ public function test_attributes_with_single_quotes(): void`
	`852`	`+ {`
	`853`	`+ $html = $this->render(<<<'HTML'`
	`854`	`+ <div class='hello'></div>`
	`855`	`+ HTML);`
	`856`	`+`
	`857`	`+ $this->assertSnippetsMatch('<div class="hello"></div>', $html);`
	`858`	`+ }`
`850`	`859`	`}`