Code Review changes

Author: WendellAdriel

packages/router/src/MatchRouteMiddleware.php

@@ -87,12 +87,9 @@ private function applyMethodSpoofing(Request $request): Request
             return $request;
         }
 
-        $spoofedMethod = $request->get('_method');
-        $spoofedEnum = ($spoofedMethod instanceof Method)
-            ? $spoofedMethod
-            : Method::tryFrom(strtoupper((string) $spoofedMethod));
+        $spoofedMethod = Method::tryFrom(strtoupper((string) $request->get('_method')));
 
-        if ($spoofedEnum === null) {
+        if ($spoofedMethod === null) {
             return $request;
         }
 
@@ -102,10 +99,10 @@ private function applyMethodSpoofing(Request $request): Request
             Method::DELETE,
         ];
 
-        if (! in_array($spoofedEnum, $allowedMethods, true)) {
+        if (! in_array($spoofedMethod, $allowedMethods, strict: true)) {
             return $request;
         }
 
-        return $request->withMethod($spoofedEnum);
+        return $request->withMethod($spoofedMethod);
     }
 }

packages/router/tests/MatchRouteMiddlewareTest.php

@@ -191,79 +191,6 @@ public function test_method_spoofing_only_applies_to_post(): void
         $this->assertInstanceOf(NotFound::class, $response);
     }
 
-    public function test_no_spoofing_without_method_parameter(): void
-    {
-        $this->addRoute(Method::POST, '/users/1');
-
-        $request = new GenericRequest(
-            method: Method::POST,
-            uri: '/users/1',
-            body: ['name' => 'John'],
-        );
-
-        $next = new HttpMiddlewareCallable(
-            fn (Request $_request) => new Ok('Middleware processed'),
-        );
-
-        $response = ($this->middleware)($request, $next);
-        $matchedRoute = $this->container->get(MatchedRoute::class);
-
-        $this->assertInstanceOf(Ok::class, $response);
-        $this->assertNotNull($matchedRoute);
-        $this->assertEquals(Method::POST, $matchedRoute->route->method);
-    }
-
-    public function test_head_to_get_fallback_still_works(): void
-    {
-        $this->addRoute(Method::GET, '/users');
-
-        $request = new GenericRequest(
-            method: Method::HEAD,
-            uri: '/users',
-        );
-
-        $next = new HttpMiddlewareCallable(
-            fn (Request $_request) => new Ok('Middleware processed'),
-        );
-
-        $response = ($this->middleware)($request, $next);
-        $matchedRoute = $this->container->get(MatchedRoute::class);
-
-        $this->assertInstanceOf(Ok::class, $response);
-        $this->assertNotNull($matchedRoute);
-        $this->assertEquals(Method::GET, $matchedRoute->route->method);
-    }
-
-    public function test_method_spoofing_preserves_request_data(): void
-    {
-        $this->addRoute(Method::PUT, '/users/1');
-
-        $request = new GenericRequest(
-            method: Method::POST,
-            uri: '/users/1',
-            body: [
-                '_method' => 'PUT',
-                'name' => 'John',
-                'email' => '[email protected]',
-            ],
-        );
-
-        $processedRequest = null;
-        $next = new HttpMiddlewareCallable(
-            function (Request $request) use (&$processedRequest) {
-                $processedRequest = $request;
-                return new Ok('Middleware processed');
-            },
-        );
-
-        ($this->middleware)($request, $next);
-
-        $this->assertNotNull($processedRequest);
-        $this->assertEquals('John', $processedRequest->get('name'));
-        $this->assertEquals('[email protected]', $processedRequest->get('email'));
-        $this->assertEquals('PUT', $processedRequest->get('_method'));
-    }
-
     private function addRoute(Method $method, string $uri): void
     {
         $route = new FakeRouteBuilder();