refactor: consistent exception naming (#1308)

Author: brendt

…ages/auth/src/CurrentUserNotLoggedIn.php …auth/src/AuthenticatedUserWasMissing.phppackages/auth/src/CurrentUserNotLoggedIn.php renamed to packages/auth/src/AuthenticatedUserWasMissing.php packages/auth/src/CurrentUserNotLoggedIn.php renamed to packages/auth/src/AuthenticatedUserWasMissing.php

@@ -6,7 +6,7 @@
 
 use Exception;
 
-final class CurrentUserNotLoggedIn extends Exception
+final class AuthenticatedUserWasMissing extends Exception
 {
     public function __construct()
     {

packages/auth/src/CurrentUserInitializer.php

@@ -22,7 +22,7 @@ public function initialize(ClassReflector $class, null|string|UnitEnum $tag, Con
         $user = $container->get(Authenticator::class)->currentUser();
 
         if (! $user) {
-            throw new CurrentUserNotLoggedIn();
+            throw new AuthenticatedUserWasMissing();
         }
 
         return $user;

packages/cache/src/CouldNotClearCache.php …ges/cache/src/CacheCouldNotBeCleared.phppackages/cache/src/CouldNotClearCache.php renamed to packages/cache/src/CacheCouldNotBeCleared.php packages/cache/src/CouldNotClearCache.php renamed to packages/cache/src/CacheCouldNotBeCleared.php

@@ -6,6 +6,6 @@
 
 use Exception;
 
-final class CouldNotClearCache extends Exception implements CacheException
+final class CacheCouldNotBeCleared extends Exception implements CacheException
 {
 }

packages/cache/src/NotNumberException.php …he/src/CacheKeyCouldNotBeIncremented.phppackages/cache/src/NotNumberException.php renamed to packages/cache/src/CacheKeyCouldNotBeIncremented.php packages/cache/src/NotNumberException.php renamed to packages/cache/src/CacheKeyCouldNotBeIncremented.php

@@ -4,7 +4,7 @@
 
 use Exception;
 
-final class NotNumberException extends Exception implements CacheException
+final class CacheKeyCouldNotBeIncremented extends Exception implements CacheException
 {
     public function __construct(
         public readonly string $key,

…che/src/ForbiddenCacheUsageException.php …ges/cache/src/CacheUsageWasForbidden.phppackages/cache/src/ForbiddenCacheUsageException.php renamed to packages/cache/src/CacheUsageWasForbidden.php packages/cache/src/ForbiddenCacheUsageException.php renamed to packages/cache/src/CacheUsageWasForbidden.php

@@ -4,7 +4,7 @@
 
 use Exception;
 
-final class ForbiddenCacheUsageException extends Exception implements CacheException
+final class CacheUsageWasForbidden extends Exception implements CacheException
 {
     public function __construct(
         public readonly ?string $tag = null,

packages/cache/src/GenericCache.php

@@ -90,7 +90,7 @@ public function increment(Stringable|string $key, int $by = 1): int
         if (! $item->isHit()) {
             $item->set($by);
         } elseif (! is_numeric($item->get())) {
-            throw new NotNumberException((string) $key);
+            throw new CacheKeyCouldNotBeIncremented((string) $key);
         } else {
             $item->set(((int) $item->get()) + $by);
         }
@@ -111,7 +111,7 @@ public function decrement(Stringable|string $key, int $by = 1): int
         if (! $item->isHit()) {
             $item->set(-$by);
         } elseif (! is_numeric($item->get())) {
-            throw new NotNumberException((string) $key);
+            throw new CacheKeyCouldNotBeIncremented((string) $key);
         } else {
             $item->set(((int) $item->get()) - $by);
         }
@@ -215,7 +215,7 @@ public function remove(Stringable|string $key): void
     public function clear(): void
     {
         if (! $this->adapter->clear()) {
-            throw new CouldNotClearCache();
+            throw new CacheCouldNotBeCleared();
         }
     }
 }

packages/cache/src/GenericLock.php

@@ -50,7 +50,7 @@ public function execute(Closure $callback, null|DateTimeInterface|Duration $wait
 
         while (! $this->acquire()) {
             if ($waitUntil->beforeOrAtTheSameTime(DateTime::now())) {
-                throw new LockAcquisitionTimedOutException($this->key);
+                throw new LockAcquisitionTimedOut($this->key);
             }
 
             usleep(250); // TODO: sleep from clock?

…src/LockAcquisitionTimedOutException.php …es/cache/src/LockAcquisitionTimedOut.phppackages/cache/src/LockAcquisitionTimedOutException.php renamed to packages/cache/src/LockAcquisitionTimedOut.php packages/cache/src/LockAcquisitionTimedOutException.php renamed to packages/cache/src/LockAcquisitionTimedOut.php

@@ -4,7 +4,7 @@
 
 use Exception;
 
-final class LockAcquisitionTimedOutException extends Exception implements CacheException
+final class LockAcquisitionTimedOut extends Exception implements CacheException
 {
     public function __construct(
         public readonly string $key,

packages/cache/src/Testing/RestrictedCache.php

@@ -6,7 +6,7 @@
 use Psr\Cache\CacheItemInterface;
 use Stringable;
 use Tempest\Cache\Cache;
-use Tempest\Cache\ForbiddenCacheUsageException;
+use Tempest\Cache\CacheUsageWasForbidden;
 use Tempest\Cache\Lock;
 use Tempest\DateTime\DateTimeInterface;
 use Tempest\DateTime\Duration;
@@ -20,56 +20,56 @@ public function __construct(
 
     public function lock(Stringable|string $key, null|Duration|DateTimeInterface $expiration = null, null|Stringable|string $owner = null): Lock
     {
-        throw new ForbiddenCacheUsageException($this->tag);
+        throw new CacheUsageWasForbidden($this->tag);
     }
 
     public function has(Stringable|string $key): bool
     {
-        throw new ForbiddenCacheUsageException($this->tag);
+        throw new CacheUsageWasForbidden($this->tag);
     }
 
     public function put(Stringable|string $key, mixed $value, null|Duration|DateTimeInterface $expiration = null): CacheItemInterface
     {
-        throw new ForbiddenCacheUsageException($this->tag);
+        throw new CacheUsageWasForbidden($this->tag);
     }
 
     public function putMany(iterable $values, null|Duration|DateTimeInterface $expiration = null): array
     {
-        throw new ForbiddenCacheUsageException($this->tag);
+        throw new CacheUsageWasForbidden($this->tag);
     }
 
     public function increment(Stringable|string $key, int $by = 1): int
     {
-        throw new ForbiddenCacheUsageException($this->tag);
+        throw new CacheUsageWasForbidden($this->tag);
     }
 
     public function decrement(Stringable|string $key, int $by = 1): int
     {
-        throw new ForbiddenCacheUsageException($this->tag);
+        throw new CacheUsageWasForbidden($this->tag);
     }
 
     public function get(Stringable|string $key): mixed
     {
-        throw new ForbiddenCacheUsageException($this->tag);
+        throw new CacheUsageWasForbidden($this->tag);
     }
 
     public function getMany(iterable $key): array
     {
-        throw new ForbiddenCacheUsageException($this->tag);
+        throw new CacheUsageWasForbidden($this->tag);
     }
 
     public function resolve(Stringable|string $key, Closure $callback, null|Duration|DateTimeInterface $expiration = null, ?Duration $stale = null): mixed
     {
-        throw new ForbiddenCacheUsageException($this->tag);
+        throw new CacheUsageWasForbidden($this->tag);
     }
 
     public function remove(Stringable|string $key): void
     {
-        throw new ForbiddenCacheUsageException($this->tag);
+        throw new CacheUsageWasForbidden($this->tag);
     }
 
     public function clear(): void
     {
-        throw new ForbiddenCacheUsageException($this->tag);
+        throw new CacheUsageWasForbidden($this->tag);
     }
 }

packages/command-bus/src/AsyncCommandRepositories/FileCommandRepository.php

@@ -5,7 +5,7 @@
 namespace Tempest\CommandBus\AsyncCommandRepositories;
 
 use Tempest\CommandBus\CommandRepository;
-use Tempest\CommandBus\Exceptions\CouldNotResolveCommand;
+use Tempest\CommandBus\Exceptions\PendingCommandCouldNotBeResolved;
 
 use function Tempest\Support\arr;
 
@@ -23,7 +23,7 @@ public function findPendingCommand(string $uuid): object
         $path = __DIR__ . "/../stored-commands/{$uuid}.pending.txt";
 
         if (! file_exists($path)) {
-            throw new CouldNotResolveCommand($uuid);
+            throw new PendingCommandCouldNotBeResolved($uuid);
         }
 
         $payload = file_get_contents($path);