fix(view): prevent compiling parent elements of minified void tags (#1055)

innocenzi · web-flow · commit 0b2597511b02 · 2025-03-20T22:18:59.000+01:00
diff --git a/src/Tempest/View/src/Renderers/TempestViewCompiler.php b/src/Tempest/View/src/Renderers/TempestViewCompiler.php
@@ -109,7 +109,7 @@ private function parseDom(string $template): NodeList
         $template = str($template)
             // Convert self-closing and void tags
             ->replaceRegex(
-                regex: '/<(?<element>\w.*?)\/>/',
+                regex: '/<(?<element>\w[^<]*?)\/>/',
                 replace: function (array $match) {
                     $element = str($match['element'])->trim();
 
diff --git a/tests/Integration/View/ViewComponentTest.php b/tests/Integration/View/ViewComponentTest.php
@@ -695,4 +695,15 @@ public function test_does_not_duplicate_br(): void
         <html lang="en"><head></head><body><br><hr></body></html>
         HTML, $html);
     }
+
+    public function test_renders_minified_html_with_void_elements(): void
+    {
+        $html = $this->render(<<<'HTML'
+            <svg xmlns="http://www.w3.org/2000/svg" width="1em" height="1em" viewBox="0 0 24 24"><g fill="none" stroke="currentColor" stroke-linecap="round" stroke-linejoin="round" stroke-width="2"><path d="M7 9.667A2.667 2.667 0 0 1 9.667 7h8.666A2.667 2.667 0 0 1 21 9.667v8.666A2.667 2.667 0 0 1 18.333 21H9.667A2.667 2.667 0 0 1 7 18.333z"/><path d="M4.012 16.737A2 2 0 0 1 3 15V5c0-1.1.9-2 2-2h10c.75 0 1.158.385 1.5 1"/></g></svg>
+        HTML);
+
+        $this->assertStringEqualsStringIgnoringLineEndings(<<<'HTML'
+        <svg xmlns="http://www.w3.org/2000/svg" width="1em" height="1em" viewbox="0 0 24 24"><g fill="none" stroke="currentColor" stroke-linecap="round" stroke-linejoin="round" stroke-width="2"><path d="M7 9.667A2.667 2.667 0 0 1 9.667 7h8.666A2.667 2.667 0 0 1 21 9.667v8.666A2.667 2.667 0 0 1 18.333 21H9.667A2.667 2.667 0 0 1 7 18.333z"></path><path d="M4.012 16.737A2 2 0 0 1 3 15V5c0-1.1.9-2 2-2h10c.75 0 1.158.385 1.5 1"></path></g></svg>
+        HTML, $html);
+    }
 }
