refactor(console): drop interactive terminal support on Windows (#1628)

xHeaven · web-flow · commit 0c03385de3b5 · 2025-10-09T06:42:49.000+02:00
diff --git a/packages/console/src/Terminal/Terminal.php b/packages/console/src/Terminal/Terminal.php
@@ -15,8 +15,6 @@
 use function function_exists;
 use function Tempest\Support\arr;
 
-use const DIRECTORY_SEPARATOR;
-
 final class Terminal
 {
     public int $width;
@@ -151,11 +149,11 @@ public function disableTty(): self
 
     public static function supportsTty(): bool
     {
-        if (! function_exists('shell_exec')) {
+        if (PHP_OS_FAMILY === 'Windows' || ! function_exists('shell_exec')) {
             return false;
         }
 
-        return (bool) shell_exec('stty 2> ' . ('\\' === DIRECTORY_SEPARATOR ? 'NUL' : '/dev/null'));
+        return (bool) shell_exec('stty 2> /dev/null');
     }
 
     private function clear(): self

Original file line number	Diff line number	Diff line change
`@@ -15,8 +15,6 @@`
`15`	`15`	`use function function_exists;`
`16`	`16`	`use function Tempest\Support\arr;`
`17`	`17`
`18`		`-use const DIRECTORY_SEPARATOR;`
`19`		`-`
`20`	`18`	`final class Terminal`
`21`	`19`	`{`
`22`	`20`	`public int $width;`
`@@ -151,11 +149,11 @@ public function disableTty(): self`
`151`	`149`
`152`	`150`	`public static function supportsTty(): bool`
`153`	`151`	`{`
`154`		`- if (! function_exists('shell_exec')) {`
	`152`	`+ if (PHP_OS_FAMILY === 'Windows' \|\| ! function_exists('shell_exec')) {`
`155`	`153`	`return false;`
`156`	`154`	`}`
`157`	`155`
`158`		`- return (bool) shell_exec('stty 2> ' . ('\\' === DIRECTORY_SEPARATOR ? 'NUL' : '/dev/null'));`
	`156`	`+ return (bool) shell_exec('stty 2> /dev/null');`
`159`	`157`	`}`
`160`	`158`
`161`	`159`	`private function clear(): self`