feat(view): more lenient DOM parsing (#941)

brendt · web-flow · commit 0fe0df917a25 · 2025-03-02T06:14:12.000+01:00
diff --git a/src/Tempest/View/src/Renderers/TempestViewCompiler.php b/src/Tempest/View/src/Renderers/TempestViewCompiler.php
@@ -108,13 +108,15 @@ private function parseDom(string $template): HTMLDocument|NodeList
             ->trim()
             ->startsWith(['<html', '<!DOCTYPE', '<!doctype']);
 
+        $parserFlags = LIBXML_HTML_NOIMPLIED | LIBXML_NOERROR | HTML_NO_DEFAULT_NS;
+
         if ($isFullHtmlDocument) {
             // If we're rendering a full HTML document, we'll parse it as is
-            return HTMLDocument::createFromString($template->toString(), LIBXML_NOERROR | HTML_NO_DEFAULT_NS);
+            return HTMLDocument::createFromString($template->toString(), $parserFlags);
         }
 
         // If we're rendering an HTML snippet, we'll wrap it in a div, and return the resulting nodelist
-        $dom = HTMLDocument::createFromString("<div id='tempest_render'>{$template}</div>", LIBXML_NOERROR | HTML_NO_DEFAULT_NS);
+        $dom = HTMLDocument::createFromString("<div id='tempest_render'>{$template}</div>", $parserFlags);
 
         return $dom->getElementById('tempest_render')->childNodes;
     }
diff --git a/tests/Integration/View/ViewComponentTest.php b/tests/Integration/View/ViewComponentTest.php
@@ -500,7 +500,7 @@ public function test_empty_slots_are_commented_out(): void
         HTML);
 
         $this->assertStringEqualsStringIgnoringLineEndings(<<<'HTML'
-        <html lang="en"><head><!--<x-slot name="styles" ></x-slot>--><link rel="stylesheet" href="#"></link></head><body></body></html>
+        <html lang="en"><head><!--<x-slot name="styles" ></x-slot>--><link rel="stylesheet" href="#"></link></head></html>
         HTML, $html);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -500,7 +500,7 @@ public function test_empty_slots_are_commented_out(): void`
`500`	`500`	`HTML);`
`501`	`501`
`502`	`502`	`$this->assertStringEqualsStringIgnoringLineEndings(<<<'HTML'`
`503`		`- <html lang="en"><head><!--<x-slot name="styles" ></x-slot>--><link rel="stylesheet" href="#"></link></head><body></body></html>`
	`503`	`+ <html lang="en"><head><!--<x-slot name="styles" ></x-slot>--><link rel="stylesheet" href="#"></link></head></html>`
`504`	`504`	`HTML, $html);`
`505`	`505`	`}`
`506`	`506`	`}`