refactor(core)!: update exception processors to no longer return a throwable (#1342)

Author: innocenzi

packages/core/src/ExceptionProcessor.php

@@ -9,5 +9,5 @@ interface ExceptionProcessor
     /**
      * Processes the given exception.
      */
-    public function process(Throwable $throwable): Throwable;
+    public function process(Throwable $throwable): void;
 }

packages/core/src/ExceptionReporter.php

@@ -19,7 +19,7 @@ public function __construct(
     ) {}
 
     /**
-     * Reports the given exception to the registered exceptionm processors.
+     * Reports the given exception to the registered exception processors.
      */
     public function report(Throwable $throwable): void
     {
@@ -29,9 +29,10 @@ public function report(Throwable $throwable): void
             return;
         }
 
+        /** @var class-string<\Tempest\Core\ExceptionProcessor> $processor */
         foreach ($this->appConfig->exceptionProcessors as $processor) {
             $handler = $this->container->get($processor);
-            $throwable = $handler->process($throwable);
+            $handler->process($throwable);
         }
     }
 }

packages/core/src/LogExceptionProcessor.php

@@ -10,7 +10,7 @@
  */
 final class LogExceptionProcessor implements ExceptionProcessor
 {
-    public function process(Throwable $throwable): Throwable
+    public function process(Throwable $throwable): void
     {
         $items = [
             'class' => $throwable::class,
@@ -21,7 +21,5 @@ public function process(Throwable $throwable): Throwable
         ];
 
         Debug::resolve()->log($items, writeToOut: false);
-
-        return $throwable;
     }
 }

tests/Integration/Http/Fixtures/NullExceptionProcessor.php

@@ -11,10 +11,8 @@ final class NullExceptionProcessor implements ExceptionProcessor
 {
     public static array $exceptions = [];
 
-    public function process(Throwable $throwable): Throwable
+    public function process(Throwable $throwable): void
     {
         static::$exceptions[] = $throwable;
-
-        return $throwable;
     }
 }