fix(filesystem): add ability to delete invalid symlinks (#1206)

Author: aazsamir

packages/support/src/Filesystem/functions.php

@@ -214,6 +214,20 @@ function delete(string $path, bool $recursive = true): void
      */
     function delete_file(string $file): void
     {
+        if (namespace\is_symbolic_link($file)) {
+            [$result, $errorMessage] = box(static fn (): bool => unlink($file));
+
+            if ($result === false && namespace\is_symbolic_link($file)) { // @phpstan-ignore booleanAnd.rightAlwaysTrue
+                throw new Exceptions\RuntimeException(sprintf(
+                    'Failed to delete symbolic link "%s": %s.',
+                    $file,
+                    $errorMessage ?? 'internal error',
+                ));
+            }
+
+            return;
+        }
+
         if (! namespace\exists($file)) {
             throw Exceptions\NotFoundException::forFile($file);
         }

packages/support/tests/Filesystem/UnixFunctionsTest.php

@@ -493,4 +493,18 @@ public function test_ensure_directory_exists_on_existent_directory(): void
 
         $this->assertTrue(is_dir($dir));
     }
+
+    public function test_delete_file_for_invalid_symlink(): void
+    {
+        $file = $this->fixtures . '/file.txt';
+        \file_put_contents($file, 'hello');
+        $link = $this->fixtures . '/link.txt';
+        symlink($file, $link);
+        unlink($file);
+
+        Filesystem\delete_file($link);
+
+        $this->assertFalse(is_file($link));
+        $this->assertFalse(is_link($link));
+    }
 }