chore: resolve phpstan issues (#825)

Author: blackshadev

phpstan-baseline.neon

@@ -5,13 +5,16 @@ includes:
 parameters:
 	level: 5
 	tmpDir: .cache/phpstan
+	tips:
+	    treatPhpDocTypesAsCertain: false
 	excludePaths:
 	    - tests/Integration/View/blade/cache/**.php
 	paths:
 		- src
 		- tests
 	ignoreErrors:
-
+		-
+			identifier: argument.named
 		-
 			message: '#.*#'
 			path: src/Tempest/Router/src/Exceptions/exception.php

phpstan.neon.dist

@@ -29,7 +29,7 @@ public function __invoke(string|array $command, string|array $arguments = []): E
         [$commandName, $arguments] = $this->resolveCommandAndArguments($command, $arguments);
 
         $consoleCommand = $this->resolveConsoleCommand($command) ?? $this->resolveConsoleCommand($commandName);
-        $callable = $this->getCallable($consoleCommand?->middleware ?? []);
+        $callable = $this->getCallable($consoleCommand->middleware ?? []);
 
         $this->argumentBag->setCommandName($consoleCommand?->getName() ?? $commandName);
         $this->argumentBag->addMany($arguments);

src/Tempest/Console/src/Actions/ExecuteConsoleCommand.php

@@ -17,6 +17,7 @@ trait OpensInEditor
 {
     private function supportsOpeningInEditor(): bool
     {
+        // @phpstan-ignore function.alreadyNarrowedType
         return is_subclass_of(static::class, CanOpenInEditor::class) && (bool) $this->getEditorCommand();
     }
 

src/Tempest/Console/src/Components/Concerns/OpensInEditor.php

@@ -120,7 +120,7 @@ private function resolveArgumentValue(
         );
     }
 
-    public function findArrayFor(ConsoleArgumentDefinition $argumentDefinition): ?ConsoleInputArgument
+    public function findArrayFor(ConsoleArgumentDefinition $argumentDefinition): ConsoleInputArgument
     {
         $values = [];
 

src/Tempest/Console/src/Input/ConsoleArgumentBag.php

@@ -31,7 +31,7 @@ public static function fromParameter(ParameterReflector $parameter): ConsoleArgu
         $boolean = $type->getName() === 'bool' || is_bool($default);
 
         return new ConsoleArgumentDefinition(
-            name: static::normalizeName($attribute?->name ?? $parameter->getName(), boolean: $boolean),
+            name: static::normalizeName($attribute->name ?? $parameter->getName(), boolean: $boolean),
             type: $type->getName(),
             default: $default,
             hasDefault: $parameter->isDefaultValueAvailable(),

src/Tempest/Console/src/Input/ConsoleArgumentDefinition.php

@@ -19,9 +19,9 @@ public function config(object $config): self;
     /**
      * @template TClassName of object
      * @param class-string<TClassName> $className
-     * @return TClassName
+     * @return null|TClassName
      */
-    public function get(string $className, ?string $tag = null, mixed ...$params): object;
+    public function get(string $className, ?string $tag = null, mixed ...$params): mixed;
 
     public function invoke(MethodReflector|FunctionReflector|callable|string $method, mixed ...$params): mixed;
 

src/Tempest/Container/src/Container.php

@@ -97,7 +97,7 @@ public function config(object $config): self
         return $this;
     }
 
-    public function get(string $className, ?string $tag = null, mixed ...$params): object
+    public function get(string $className, ?string $tag = null, mixed ...$params): null|object
     {
         $this->resolveChain();
 
@@ -213,7 +213,7 @@ public function addInitializer(ClassReflector|string $initializerClass): Contain
         return $this;
     }
 
-    private function resolve(string $className, ?string $tag = null, mixed ...$params): object
+    private function resolve(string $className, ?string $tag = null, mixed ...$params): null|object
     {
         $class = new ClassReflector($className);
 

src/Tempest/Container/src/GenericContainer.php

@@ -138,7 +138,6 @@ public function test_arrays_are_automatically_created(): void
          */
         $class = $container->get(BuiltinArrayClass::class);
 
-        $this->assertIsArray($class->anArray);
         $this->assertEmpty($class->anArray);
     }