feat(console): support negative arguments (#660)

Author: innocenzi

src/Tempest/Console/src/Input/ConsoleInputArgument.php

@@ -4,6 +4,8 @@
 
 namespace Tempest\Console\Input;
 
+use function Tempest\Support\str;
+
 final class ConsoleInputArgument
 {
     public function __construct(
@@ -56,23 +58,28 @@ public function matches(string $name): bool
      */
     private static function parseNamedArgument(string $argument): array
     {
-        preg_match('/--(?<name>[\w]+)((?<hasValue>=)\"?(?<value>(.*?))(\"|$))?/', $argument, $matches);
+        preg_match('/--(?<name>[\w-]+)((?<hasValue>=)\"?(?<value>(.*?))(\"|$))?/', $argument, $matches);
 
-        $name = $matches['name'] ?? null;
+        $name = str($matches['name'] ?? null)->kebab()->toString();
+        $normalizedName = str($matches['name'] ?? null)->kebab()->replaceStart('no-', '')->toString();
+        $isNegative = str($matches['name'] ?? null)->kebab()->startsWith('no-');
         $hasValue = $matches['hasValue'] ?? null;
         $value = $matches['value'] ?? null;
 
         if (! $hasValue) {
-            return [$name, true];
+            return [$normalizedName, $isNegative ? false : true];
         }
 
         $value = match ($value) {
-            'true' => true,
-            'false' => false,
+            'true' => $isNegative ? false : true,
+            'false' => $isNegative ? true : false,
             '' => null,
             default => $value,
         };
 
-        return [$name, $value];
+        return [
+            is_bool($value) ? $normalizedName : $name,
+            $value,
+        ];
     }
 }

tests/Integration/Console/ConsoleArgumentBagTest.php

@@ -4,6 +4,7 @@
 
 namespace Tests\Tempest\Integration\Console;
 
+use PHPUnit\Framework\Attributes\TestWith;
 use Tempest\Console\Input\ConsoleArgumentBag;
 use Tempest\Console\Input\ConsoleArgumentDefinition;
 use Tests\Tempest\Integration\FrameworkIntegrationTestCase;
@@ -107,4 +108,34 @@ public function test_array_with_one_element_to_command(): void
             ->call('array_input --input=a')
             ->assertContains('["a"]');
     }
+
+    #[TestWith(['foo', false])]
+    #[TestWith(['bar', true])]
+    #[TestWith(['baz', false])]
+    #[TestWith(['qux', true])]
+    #[TestWith(['bux', true])]
+    public function test_negative_input(string $name, bool $expected): void
+    {
+        $argv = [
+            'tempest',
+            'test',
+            '--no-foo',
+            '--qux',
+            '--bux=true',
+            '--no-bar=false',
+            '--baz=false',
+        ];
+
+        $bag = new ConsoleArgumentBag($argv);
+
+        $definition = new ConsoleArgumentDefinition(
+            name: $name,
+            type: 'bool',
+            default: null,
+            hasDefault: false,
+            position: 0,
+        );
+
+        $this->assertSame($expected, $bag->findFor($definition)->value);
+    }
 }

tests/Integration/Console/Input/ConsoleInputArgumentTest.php

@@ -31,5 +31,32 @@ public function test_parse_named_arguments(): void
 
         $input = ConsoleInputArgument::fromString('--flag="abc"');
         $this->assertSame('abc', $input->value);
+
+        $input = ConsoleInputArgument::fromString('--foo-bar="baz"');
+        $this->assertSame('foo-bar', $input->name);
+        $this->assertSame('baz', $input->value);
+
+        $input = ConsoleInputArgument::fromString('--fooBar');
+        $this->assertSame('foo-bar', $input->name);
+
+        $input = ConsoleInputArgument::fromString('--noFooBar');
+        $this->assertSame('foo-bar', $input->name);
+        $this->assertSame(false, $input->value);
+
+        $input = ConsoleInputArgument::fromString('--no-interaction');
+        $this->assertSame('interaction', $input->name);
+        $this->assertSame(false, $input->value);
+
+        $input = ConsoleInputArgument::fromString('--no-interaction=true');
+        $this->assertSame('interaction', $input->name);
+        $this->assertSame(false, $input->value);
+
+        $input = ConsoleInputArgument::fromString('--no-interaction=false');
+        $this->assertSame('interaction', $input->name);
+        $this->assertSame(true, $input->value);
+
+        $input = ConsoleInputArgument::fromString('--no-foo=baz');
+        $this->assertSame('no-foo', $input->name);
+        $this->assertSame('baz', $input->value);
     }
 }