feat(view): prevent invalid closing tags (#1195)

Author: brendt

packages/view/src/Exceptions/InvalidClosingTag.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace Tempest\View\Exceptions;
+
+use Exception;
+
+final class InvalidClosingTag extends Exception
+{
+    public function __construct(string $openTag, string $closingTag)
+    {
+        parent::__construct("Invalid closing tag `{$closingTag}` for opening tag `{$openTag}`");
+    }
+}

packages/view/src/Parser/Token.php

@@ -2,6 +2,8 @@
 
 namespace Tempest\View\Parser;
 
+use Tempest\View\Exceptions\InvalidClosingTag;
+
 use function Tempest\Support\str;
 
 final class Token
@@ -79,6 +81,10 @@ public function setEndingToken(Token $endingToken): void
 
     public function setClosingToken(Token $closingToken): void
     {
+        if ($closingToken->tag && $this->tag !== $closingToken->tag) {
+            throw new InvalidClosingTag($this->tag, $closingToken->tag);
+        }
+
         $this->closingToken = $closingToken;
     }
 

packages/view/tests/Fixtures/html/4.html

@@ -108,7 +108,7 @@ <h1 id="top" class="mt-2 font-bold text-4xl text-(--ui-text-highlighted) lg:scro
                                 </li>
                                 <li :foreach="$chapter['children'] as $url => $title">
                                     <a :href="$url" :data-on-this-page="$title" class="pl-4 group relative text-sm flex items-center focus-visible:outline-(--ui-primary) py-1 text-(--ui-text-dimmed) hover:text-(--ui-text) data-[active]:text-(--ui-primary) transition-colors">
-                                        {{ \Tempest\Support\Str\strip_tags($title) }}</span>
+                                        <span>{{ \Tempest\Support\Str\strip_tags($title) }}</span>
                                     </a>
                                 </li>
                             </x-template>

packages/view/tests/TempestViewParserTest.php

@@ -5,6 +5,7 @@
 use Generator;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
+use Tempest\View\Exceptions\InvalidClosingTag;
 use Tempest\View\Parser\TempestViewLexer;
 use Tempest\View\Parser\TempestViewParser;
 use Tempest\View\Parser\Token;
@@ -66,6 +67,15 @@ public function test_self_closing_tags_with_attributes(): void
         HTML, $ast->compile());
     }
 
+    public function test_invalid_closing_tag(): void
+    {
+        $tokens = new TempestViewLexer('<a></span></a>')->lex();
+
+        $this->expectException(InvalidClosingTag::class);
+
+        new TempestViewParser($tokens)->parse();
+    }
+
     public function test_doctype(): void
     {
         $tokens = new TokenCollection([

tests/Integration/View/ViewComponentDiscoveryTest.php

@@ -53,7 +53,7 @@ public function test_auto_registration_with_x_component(): void
         $discovery->apply();
 
         $html = $this->render(<<<'HTML'
-        <x-auto-registered-with-declaration></x-auto-registered-with-x-component>
+        <x-auto-registered-with-declaration></x-auto-registered-with-declaration>
         HTML);
 
         $this->assertSame('<span>Hello World</span>', $html);