fix(view): throw exception when parsing xml views with short_open_tag enabled (#1795)

Author: innocenzi

packages/view/src/Exceptions/XmlDeclarationCouldNotBeParsed.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tempest\View\Exceptions;
+
+use Exception;
+
+final class XmlDeclarationCouldNotBeParsed extends Exception
+{
+    public function __construct()
+    {
+        parent::__construct('Cannot compile views with XML declarations when PHP\'s `short_open_tag` is enabled.');
+    }
+}

packages/view/src/Parser/TempestViewCompiler.php

@@ -11,6 +11,7 @@
 use Tempest\View\Element;
 use Tempest\View\Elements\ElementFactory;
 use Tempest\View\Exceptions\ViewNotFound;
+use Tempest\View\Exceptions\XmlDeclarationCouldNotBeParsed;
 use Tempest\View\ShouldBeRemoved;
 use Tempest\View\View;
 
@@ -40,6 +41,11 @@ public function compile(string|View $view): string
         // 1. Retrieve template
         $template = $this->retrieveTemplate($view);
 
+        // Check for XML declarations when short_open_tag is enabled
+        if (ini_get('short_open_tag') && str_contains($template, needle: '<?xml')) {
+            throw new XmlDeclarationCouldNotBeParsed();
+        }
+
         // 2. Remove comments before parsing
         $template = $this->removeComments($template);
 

packages/view/tests/StandaloneViewRendererTest.php

@@ -5,6 +5,7 @@
 use PHPUnit\Framework\TestCase;
 use Tempest\View\Exceptions\ViewComponentPathWasInvalid;
 use Tempest\View\Exceptions\ViewComponentPathWasNotFound;
+use Tempest\View\Exceptions\XmlDeclarationCouldNotBeParsed;
 use Tempest\View\Renderers\TempestViewRenderer;
 use Tempest\View\ViewCache;
 use Tempest\View\ViewComponent;
@@ -106,6 +107,18 @@ public function test_with_cache_disabled(): void
         HTML, $html);
     }
 
+    public function test_xml_declaration_with_short_open_tag(): void
+    {
+        if (! ini_get('short_open_tag')) {
+            $this->markTestSkipped('This test requires short_open_tag to be enabled.');
+        }
+
+        $this->expectException(XmlDeclarationCouldNotBeParsed::class);
+
+        $renderer = TempestViewRenderer::make();
+        $renderer->render('<?xml version="1.0" encoding="UTF-8" ?><test></test>');
+    }
+
     protected function assertSnippetsMatch(string $expected, string $actual): void
     {
         $expected = str_replace([PHP_EOL, ' '], '', $expected);

tests/Integration/View/TempestViewRendererTest.php

@@ -8,6 +8,7 @@
 use Tempest\Discovery\DiscoveryLocation;
 use Tempest\Support\Html\HtmlString;
 use Tempest\View\Exceptions\ElementWasInvalid;
+use Tempest\View\Exceptions\XmlDeclarationCouldNotBeParsed;
 use Tempest\View\Renderers\TempestViewRenderer;
 use Tempest\View\ViewCache;
 use Tests\Tempest\Fixtures\Controllers\RelativeViewController;
@@ -800,7 +801,7 @@ public function test_multiline_view_comments(): void
                 <x-input
                     name="test"
                     type="text"
-                    class="block dark:bg-neutral-900 disabled:opacity-50 px-4 py-2.5 sm:py-3 border-1 border-gray-500 dark:border-neutral-700 focus:border-blue-500 rounded-lg focus:ring-blue-500 dark:focus:ring-neutral-600 w-full dark:text-neutral-400 sm:text-sm disabled:pointer-events-none dark:placeholder-neutral-500" placeholder="This is placeholder" />
+                    class="block dark:bg-neutral-900 disabled:opacity-50 px-4 py-2.5 sm:py-3 border-1 border-gray-500 focus:border-blue-500 dark:border-neutral-700 rounded-lg focus:ring-blue-500 dark:focus:ring-neutral-600 w-full dark:text-neutral-400 sm:text-sm disabled:pointer-events-none dark:placeholder-neutral-500" placeholder="This is placeholder" />
                 <!-- end -->
             </div>
             --}}
@@ -812,6 +813,10 @@ class="block dark:bg-neutral-900 disabled:opacity-50 px-4 py-2.5 sm:py-3 border-
 
     public function test_parse_rss_feed(): void
     {
+        if (ini_get('short_open_tag')) {
+            $this->expectException(XmlDeclarationCouldNotBeParsed::class);
+        }
+
         $rss = <<<'XML'
         <?xml version="1.0" encoding="UTF-8" ?>
         <feed xmlns="http://www.w3.org/2005/Atom" xmlns:media="http://search.yahoo.com/mrss/">