fix(generation): simplify traits and method parameter attributes (#753)

Author: gturpin-dev

src/Tempest/Generation/src/SimplifiesClassNames.php

@@ -67,11 +67,19 @@ private function simplifyClassNames(PhpFile $file): PhpFile
                     $types[] = $attribute->getName();
                 }
 
+                foreach ($class->getTraits() as $trait) {
+                    $types[] = $trait->getName();
+                }
+
                 foreach ($class->getMethods() as $method) {
                     $types[] = $method->getReturnType(true);
 
                     foreach ($method->getParameters() as $parameter) {
                         $types[] = $parameter->getType(true);
+
+                        foreach ($parameter->getAttributes() as $attribute) {
+                            $types[] = $attribute->getName();
+                        }
                     }
 
                     foreach ($method->getAttributes() as $attribute) {

src/Tempest/Generation/tests/ClassManipulatorTest.php

@@ -6,6 +6,8 @@
 
 use PHPUnit\Framework\Attributes\Test;
 use Tempest\Generation\ClassManipulator;
+use Tempest\Generation\Tests\Fixtures\ClassWithMethodParameterAttributes;
+use Tempest\Generation\Tests\Fixtures\ClassWithTraitInAnotherNamespace;
 use Tempest\Generation\Tests\Fixtures\CreateMigrationsTable;
 use Tempest\Generation\Tests\Fixtures\Database\MigrationModel;
 use Tempest\Generation\Tests\Fixtures\TestAttribute;
@@ -161,4 +163,20 @@ public function manipulates_classes(): void
 
         $this->assertMatchesSnapshot($class->print());
     }
+
+    #[Test]
+    public function simplifies_traits_from_another_namespace(): void
+    {
+        $class = new ClassManipulator(ClassWithTraitInAnotherNamespace::class);
+
+        $this->assertMatchesSnapshot($class->print());
+    }
+
+    #[Test]
+    public function simplifies_method_parameter_attributes(): void
+    {
+        $class = new ClassManipulator(ClassWithMethodParameterAttributes::class);
+
+        $this->assertMatchesSnapshot($class->print());
+    }
 }

src/Tempest/Generation/tests/Fixtures/ClassWithMethodParameterAttributes.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tempest\Generation\Tests\Fixtures;
+
+use Tempest\Generation\Tests\Fixtures\SampleNamespace\SampleParameterAttribute;
+
+final class ClassWithMethodParameterAttributes
+{
+    public function example(
+        #[SampleParameterAttribute]
+        string $parameter
+    ): void {
+    }
+}

src/Tempest/Generation/tests/Fixtures/ClassWithTraitInAnotherNamespace.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tempest\Generation\Tests\Fixtures;
+
+use Tempest\Generation\Tests\Fixtures\SampleNamespace\ExampleTrait;
+
+final class ClassWithTraitInAnotherNamespace
+{
+    use ExampleTrait;
+}

src/Tempest/Generation/tests/Fixtures/SampleNamespace/ExampleTrait.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tempest\Generation\Tests\Fixtures\SampleNamespace;
+
+trait ExampleTrait
+{
+    public function traitMethod(): void
+    {
+    }
+}

src/Tempest/Generation/tests/Fixtures/SampleNamespace/SampleParameterAttribute.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tempest\Generation\Tests\Fixtures\SampleNamespace;
+
+use Attribute;
+
+#[Attribute(Attribute::TARGET_PARAMETER)]
+final class SampleParameterAttribute
+{
+}

src/Tempest/Generation/tests/__snapshots__/ClassManipulatorTest__simplifies_method_parameter_attributes__1.txt

@@ -0,0 +1,14 @@
+<?php
+
+namespace Tempest\Generation\Tests\Fixtures;
+
+use Tempest\Generation\Tests\Fixtures\SampleNamespace\SampleParameterAttribute;
+
+final class ClassWithMethodParameterAttributes
+{
+    public function example(
+        #[SampleParameterAttribute]
+        string $parameter,
+    ): void {
+    }
+}

src/Tempest/Generation/tests/__snapshots__/ClassManipulatorTest__simplifies_method_property_attributes__1.txt

@@ -0,0 +1,14 @@
+<?php
+
+namespace Tempest\Generation\Tests\Fixtures;
+
+use Tempest\Generation\Tests\Fixtures\SampleNamespace\SamplePropertyAttribute;
+
+final class ClassWithMethodPropertyAttributes
+{
+    public function example(
+        #[SamplePropertyAttribute]
+        string $parameter,
+    ): void {
+    }
+}

src/Tempest/Generation/tests/__snapshots__/ClassManipulatorTest__simplifies_trait_from_another_namespace__1.txt

@@ -0,0 +1,10 @@
+<?php
+
+namespace Tempest\Generation\Tests\Fixtures;
+
+use Tempest\Generation\Tests\Fixtures\SampleNamespace\ExampleTrait;
+
+final class ClassWithTraitInAnotherNamespace
+{
+    use ExampleTrait;
+}

src/Tempest/Generation/tests/__snapshots__/ClassManipulatorTest__simplifies_traits_from_another_namespace__1.txt

@@ -0,0 +1,10 @@
+<?php
+
+namespace Tempest\Generation\Tests\Fixtures;
+
+use Tempest\Generation\Tests\Fixtures\SampleNamespace\ExampleTrait;
+
+final class ClassWithTraitInAnotherNamespace
+{
+    use ExampleTrait;
+}