change file read lock scope to only interact with sessions

Author: ewingd

packages/http/src/Session/Managers/FileSessionManager.php

@@ -81,8 +81,14 @@ private function resolve(SessionId $id): ?Session
                 return null;
             }
 
+            $file_pointer = fopen($path, 'rb');
+            flock($file_pointer, LOCK_SH);
+
             $content = Filesystem\read_file($path);
 
+            flock($file_pointer, LOCK_UN);
+            fclose($file_pointer);
+
             return unserialize($content, ['allowed_classes' => true]);
         } catch (Throwable) {
             return null;

packages/support/src/Filesystem/functions.php

@@ -120,15 +120,7 @@ function read_file(string $filename): string
         throw Exceptions\PathWasNotReadable::forFile($filename);
     }
 
-    [$result, $message] = box(static function () use ($filename): false|string {
-        $file_pointer = fopen($filename, 'rb');
-        flock($file_pointer, LOCK_SH);
-        $contents = file_get_contents($filename);
-        flock($file_pointer, LOCK_UN);
-        fclose($file_pointer);
-
-        return $contents;
-    });
+    [$result, $message] = box(static fn (): false|string => file_get_contents($filename));
 
     if (false === $result) {
         throw new Exceptions\RuntimeException(sprintf(