wip add test and do some fixes

NeoIsRecursive · NeoIsRecursive · commit 47e1af14bd68 · 2025-07-12T13:25:34.000+02:00
diff --git a/packages/vite/src/TagsResolver/DevelopmentTagsResolver.php b/packages/vite/src/TagsResolver/DevelopmentTagsResolver.php
@@ -35,7 +35,7 @@ public function resolveTags(array $entrypoints): array
             ->prepend($this->createDevelopmentTag(self::CLIENT_SCRIPT_PATH));
 
         if ($this->bridgeFile->needsReactRefresh) {
-            $tags->prepend($this->createReactRefreshTag());
+            $tags = $tags->prepend($this->createReactRefreshTag());
         }
 
         return $tags->toArray();
@@ -72,11 +72,11 @@ private function createReactRefreshTag(): string
     {
         return <<<HTML
             <script type="module">
-                import RefreshRuntime from '{$this->bridgeFile->url}/@react-refresh'
-                RefreshRuntime.injectIntoGlobalHook(window)
-                window.\$RefreshReg$ = () => {}
-                window.\$RefreshSig$ = () => (type) => type
-                window.__vite_plugin_react_preamble_installed__ = true
+                import RefreshRuntime from '{$this->bridgeFile->url}/@react-refresh';
+                RefreshRuntime.injectIntoGlobalHook(window);
+                window.\$RefreshReg$ = () => {};
+                window.\$RefreshSig$ = () => (type) => type;
+                window.__vite_plugin_react_preamble_installed__ = true;
             </script>
         HTML;
     }
diff --git a/packages/vite/src/Vite.php b/packages/vite/src/Vite.php
@@ -140,7 +140,7 @@ private function getBridgeFile(): ViteBridgeFile
 
         return static::$bridgeFile = new ViteBridgeFile(
             url: $content->get('url'),
-            needsReactRefresh: $content->get('needsReactRefresh', false),
+            needsReactRefresh: $content->get('needsReactRefresh', default: false),
         );
     }
 
diff --git a/tests/Integration/Vite/ViteTagsComponentTest.php b/tests/Integration/Vite/ViteTagsComponentTest.php
@@ -121,6 +121,49 @@ public function test_dev_entrypoints_from_config(): void
         );
     }
 
+    public function test_dev_entrypoints_from_config_and_react_refresh_from_bridgefile(): void
+    {
+        $this->vite->call(
+            callback: function (): void {
+                $this->container->config(new ViteConfig(
+                    entrypoints: ['src/foo.ts', 'src/bar.css'],
+                ));
+
+                $html = $this->render(<<<'HTML'
+                <html lang="en">
+                <head>
+                    <x-vite-tags :entrypoint="['src/foo.ts', 'src/bar.css']" />
+                </head>
+                <body>Foo</body>
+                </html>
+                HTML);
+
+                $this->assertSnippetsMatch(
+                    expected: <<<HTML
+                    <html lang="en"><head>
+                    <script type="module">
+                        import RefreshRuntime from 'http://localhost:5173/@react-refresh';
+                        RefreshRuntime.injectIntoGlobalHook(window);
+                        window.\$RefreshReg$ = () => {};
+                        window.\$RefreshSig$ = () => (type) => type;
+                        window.__vite_plugin_react_preamble_installed__ = true;
+                    </script><script type="module" src="http://localhost:5173/@vite/client"></script><script type="module" src="http://localhost:5173/src/foo.ts"></script><link rel="stylesheet" href="http://localhost:5173/src/bar.css" /></head><body>Foo
+                    </body></html>
+                    HTML,
+                    actual: $html,
+                );
+            },
+            files: [
+                'public/vite-tempest' => [
+                    'url' => 'http://localhost:5173',
+                    'needsReactRefresh' => true,
+                ],
+                'src/foo.ts' => '',
+                'src/bar.css' => '',
+            ],
+        );
+    }
+
     public function test_production_entrypoint_from_config(): void
     {
         $this->vite->call(

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ private function getBridgeFile(): ViteBridgeFile`
`140`	`140`
`141`	`141`	`return static::$bridgeFile = new ViteBridgeFile(`
`142`	`142`	`url: $content->get('url'),`
`143`		`- needsReactRefresh: $content->get('needsReactRefresh', false),`
	`143`	`+ needsReactRefresh: $content->get('needsReactRefresh', default: false),`
`144`	`144`	`);`
`145`	`145`	`}`
`146`	`146`