fix(validation): prevent type errors in rules using preg_match (#1043)

Co-authored-by: Wilfried JOnker <[email protected]>

Author: Blurazzle

src/Tempest/Validation/src/Rules/Alpha.php

@@ -12,6 +12,10 @@
 {
     public function isValid(mixed $value): bool
     {
+        if (! is_string($value)) {
+            return false;
+        }
+
         return boolval(preg_match('/^[A-Za-z]+$/', $value));
     }
 

src/Tempest/Validation/src/Rules/AlphaNumeric.php

@@ -12,6 +12,10 @@
 {
     public function isValid(mixed $value): bool
     {
+        if (! is_string($value)) {
+            return false;
+        }
+
         return boolval(preg_match('/^[A-Za-z0-9]+$/', $value));
     }
 

src/Tempest/Validation/src/Rules/Numeric.php

@@ -12,6 +12,10 @@
 {
     public function isValid(mixed $value): bool
     {
+        if (! is_string($value)) {
+            return false;
+        }
+
         return boolval(preg_match('/^[0-9]+$/', $value));
     }
 

src/Tempest/Validation/src/Rules/RegEx.php

@@ -17,6 +17,10 @@ public function __construct(
 
     public function isValid(mixed $value): bool
     {
+        if (! is_string($value)) {
+            return false;
+        }
+
         return preg_match($this->pattern, $value) === 1;
     }
 

src/Tempest/Validation/src/Rules/Time.php

@@ -17,6 +17,10 @@ public function __construct(
 
     public function isValid(mixed $value): bool
     {
+        if (! is_string($value)) {
+            return false;
+        }
+
         if ($this->twentyFourHour) {
             return preg_match('/^([0-1][0-9]|2[0-3]):?[0-5][0-9]$|^(([0-1]?[0-9]|2[0-3]):[0-5][0-9])$/', $value) === 1;
         }

src/Tempest/Validation/src/Rules/Ulid.php

@@ -12,6 +12,10 @@
 {
     public function isValid(mixed $value): bool
     {
+        if (! is_string($value)) {
+            return false;
+        }
+
         return preg_match('/^[0-9A-HJKMNP-TV-Z]{26}$/i', $value) === 1;
     }
 

src/Tempest/Validation/src/Rules/Uuid.php

@@ -12,6 +12,10 @@
 {
     public function isValid(mixed $value): bool
     {
+        if (! is_string($value)) {
+            return false;
+        }
+
         return boolval(preg_match('/^[a-f\d]{8}(-[a-f\d]{4}){4}[a-f\d]{8}$/i', $value));
     }
 

src/Tempest/Validation/tests/Rules/AlphaNumericTest.php

@@ -20,5 +20,6 @@ public function test_alphanumeric(): void
         $this->assertFalse($rule->isValid('string_123'));
         $this->assertTrue($rule->isValid('string123'));
         $this->assertTrue($rule->isValid('STRING123'));
+        $this->assertFalse($rule->isValid([])); // Should return false, not a TypeError from preg_match
     }
 }

src/Tempest/Validation/tests/Rules/AlphaTest.php

@@ -20,5 +20,6 @@ public function test_alpha(): void
         $this->assertFalse($rule->isValid('string123'));
         $this->assertTrue($rule->isValid('string'));
         $this->assertTrue($rule->isValid('STRING'));
+        $this->assertFalse($rule->isValid([])); // Should return false, not a TypeError from preg_match
     }
 }

src/Tempest/Validation/tests/Rules/RegexTest.php

@@ -28,4 +28,15 @@ public function test_regex_rule(): void
         $this->assertTrue($rule->isValid('AB'));
         $this->assertTrue($rule->isValid('Ab'));
     }
+
+    public function test_non_imvalid_types(): void
+    {
+        $rule = new RegEx('/^[0-9]+$/');
+
+        // Invalid types should return false, not a TypeError.
+        $this->assertFalse($rule->isValid(false));
+        $this->assertFalse($rule->isValid([]));
+        $this->assertFalse($rule->isValid(new \stdClass()));
+        $this->assertFalse($rule->isValid(null));
+    }
 }