refactor(database): minor cleanup (#1768)

Author: xHeaven

packages/database/src/Builder/QueryBuilders/InsertQueryBuilder.php

@@ -145,18 +145,14 @@ private function convertObjectToArray(object $object, array $excludeProperties =
         $data = [];
 
         foreach ($reflection->getPublicProperties() as $property) {
-            if (! $property->isInitialized($object)) {
+            if ($property->isUninitialized($object)) {
                 continue;
             }
 
             if ($property->isVirtual()) {
                 continue;
             }
 
-            if ($property->isUninitialized($object)) {
-                continue;
-            }
-
             $propertyName = $property->getName();
 
             if (! in_array($propertyName, $excludeProperties, strict: true)) {

packages/database/src/Migrations/MigrationManager.php

@@ -247,10 +247,6 @@ public function executeDown(MigratesDown $migration): void
 
         $statement = $migration->down();
 
-        if ($statement === null) {
-            return;
-        }
-
         $query = new Query($statement->compile($this->dialect));
 
         try {
@@ -261,10 +257,10 @@ public function executeDown(MigratesDown $migration): void
 
             $this->database->execute($query);
 
-            // Disable foreign key checks
+            // Enable foreign key checks
             new SetForeignKeyChecksStatement(enable: true)->execute($this->dialect, $this->onDatabase);
         } catch (QueryWasInvalid $queryWasInvalid) {
-            // Disable foreign key checks
+            // Enable foreign key checks
             new SetForeignKeyChecksStatement(enable: true)->execute($this->dialect, $this->onDatabase);
 
             event(new MigrationFailed($migration->name, $queryWasInvalid));

packages/database/src/Transactions/GenericTransactionManager.php

@@ -35,7 +35,7 @@ public function commit(): void
 
     public function rollback(): void
     {
-        $transactionRolledBack = $this->connection->rollBack();
+        $transactionRolledBack = $this->connection->rollback();
 
         if (! $transactionRolledBack) {
             throw new CouldNotRollbackTransaction();