ci: disable cs fixer and fix qa errors (#892)

Author: brendt

composer.json

@@ -170,7 +170,6 @@
             "./bin/validate-packages",
             "./tempest discovery:clear",
             "composer rector",
-            "composer csfixer",
             "composer phpunit",
             "composer phpstan"
         ]

phpstan.neon.dist

@@ -18,8 +18,6 @@ parameters:
 		- src
 		- tests
 	ignoreErrors:
-		-
-			identifier: assign.propertyReadOnly
 		-
 			identifier: argument.named
 		-

src/Tempest/Console/tests/TextBufferTest.php

@@ -281,6 +281,7 @@ public function test_relative_cursor_index(string $initialText, int $cursor, arr
         $buffer = new TextBuffer($initialText);
 
         $buffer->cursor = $cursor;
+
         $point = $buffer->getRelativeCursorPosition();
 
         $this->assertSame($expectedPoint[0], $point->x);
@@ -296,6 +297,7 @@ public function test_relative_cursor_index_with_wrapping(string $initialText, in
         $buffer = new TextBuffer($initialText);
 
         $buffer->cursor = $cursor;
+
         $point = $buffer->getRelativeCursorPosition($maxLineWidth);
 
         $this->assertSame($expectedPoint[0], $point->x);

src/Tempest/Framework/Testing/ViteTester.php

@@ -72,6 +72,7 @@ public function allowUsingManifest(): self
     {
         $config = $this->container->get(ViteConfig::class);
         $config->useManifestDuringTesting = true;
+
         $this->container->config($config);
 
         return $this;
@@ -84,6 +85,7 @@ public function preventUsingManifest(): self
     {
         $config = $this->container->get(ViteConfig::class);
         $config->useManifestDuringTesting = false;
+
         $this->container->config($config);
 
         return $this;

src/Tempest/Router/src/Route.php

@@ -12,6 +12,6 @@ interface Route
 
     public string $uri { get; }
 
-    /** @var HttpMiddleware[]  */
+    /** @var class-string<HttpMiddleware>[]  */
     public array $middleware { get; }
 }

src/Tempest/Router/src/Routing/Construction/DiscoveredRoute.php

@@ -6,6 +6,7 @@
 
 use Tempest\Http\Method;
 use Tempest\Reflection\MethodReflector;
+use Tempest\Router\HttpMiddleware;
 use Tempest\Router\Route;
 
 final class DiscoveredRoute implements Route
@@ -33,6 +34,7 @@ private function __construct(
         public readonly string $uri,
         public readonly Method $method,
         public readonly array $parameters,
+        /** @var class-string<HttpMiddleware>[] */
         public readonly array $middleware,
         public readonly MethodReflector $handler,
     ) {

src/Tempest/Router/tests/FakeRouteBuilder.php

@@ -7,6 +7,7 @@
 use ReflectionMethod;
 use Tempest\Http\Method;
 use Tempest\Reflection\MethodReflector;
+use Tempest\Router\HttpMiddleware;
 use Tempest\Router\Route;
 use Tempest\Router\Routing\Construction\DiscoveredRoute;
 use Tempest\Router\Routing\Construction\MarkedRoute;
@@ -18,6 +19,7 @@
     public function __construct(
         public Method $method = Method::GET,
         public string $uri = '/',
+        /** @var class-string<HttpMiddleware>[] */
         public array $middleware = [],
     ) {
         $this->handler = new MethodReflector(new ReflectionMethod($this, 'handler'));