refactor(core): remove unnecessary set hook from Kernel interface (#959)

Author: brendt

src/Tempest/Core/src/FrameworkKernel.php

@@ -105,6 +105,7 @@ public function loadEnv(): self
     public function registerKernel(): self
     {
         $this->container->singleton(Kernel::class, $this);
+        $this->container->singleton(self::class, $this);
 
         return $this;
     }

src/Tempest/Core/src/Kernel.php

@@ -28,7 +28,6 @@ interface Kernel
 
     public string $internalStorage {
         get;
-        set;
     }
 
     public array $discoveryLocations {

src/Tempest/Support/tests/Arr/ToArrayTest.php

@@ -126,8 +126,8 @@ public function test_regular_object_is_wrapped(): void
     {
         $object = new class () {
             public $foo = 'bar';
+
             public $baz = 42;
-            private $hidden = 'secret'; // @phpstan-ignore-line not used on purpose
         };
 
         $this->assertEquals([$object], to_array($object));

src/Tempest/View/src/Renderers/TempestViewCompiler.php

@@ -127,7 +127,7 @@ private function parseDom(string $template): NodeList
         );
 
         // If we have head nodes and a head tag, we inject them back
-        if ($headElement = $dom->getElementsByTagName('head')->item(0)) {
+        if (($headElement = $dom->getElementsByTagName('head')->item(0)) !== null) {
             foreach ($headNodes as $headNode) {
                 $headElement->appendChild($dom->importNode($headNode, deep: true));
             }

tests/Fixtures/Controllers/JsonController.php

@@ -9,7 +9,7 @@
 final class JsonController
 {
     #[Post('/json-endpoint')]
-    public function __invoke(Request $request)
+    public function __invoke(Request $request): \Tempest\Router\Responses\Ok
     {
         return new Ok($request->get('title'));
     }

tests/Integration/Auth/AuthorizerTest.php

@@ -10,6 +10,7 @@
 use Tempest\Auth\Install\CreateUsersTable;
 use Tempest\Auth\Install\User;
 use Tempest\Clock\Clock;
+use Tempest\Core\FrameworkKernel;
 use Tempest\Core\Kernel;
 use Tempest\Database\Migrations\CreateMigrationsTable;
 use Tempest\Filesystem\LocalFilesystem;
@@ -27,6 +28,7 @@
 final class AuthorizerTest extends FrameworkIntegrationTestCase
 {
     private string $path = __DIR__ . '/Fixtures/tmp';
+
     private LocalFilesystem $filesystem;
 
     protected function setUp(): void
@@ -45,7 +47,7 @@ protected function setUp(): void
         $this->filesystem->deleteDirectory($this->path, recursive: true);
         $this->filesystem->ensureDirectoryExists($this->path);
 
-        $this->container->get(Kernel::class)->internalStorage = realpath($this->path);
+        $this->container->get(FrameworkKernel::class)->internalStorage = realpath($this->path);
 
         $this->container->config(new SessionConfig(path: 'sessions'));
         $this->container->singleton(

tests/Integration/Auth/SessionAuthenticatorTest.php

@@ -12,6 +12,7 @@
 use Tempest\Auth\Install\User;
 use Tempest\Auth\SessionAuthenticator;
 use Tempest\Clock\Clock;
+use Tempest\Core\FrameworkKernel;
 use Tempest\Core\Kernel;
 use Tempest\Database\Migrations\CreateMigrationsTable;
 use Tempest\Filesystem\LocalFilesystem;
@@ -27,6 +28,7 @@
 final class SessionAuthenticatorTest extends FrameworkIntegrationTestCase
 {
     private string $path = __DIR__ . '/Fixtures/tmp';
+
     private LocalFilesystem $filesystem;
 
     protected function setUp(): void
@@ -38,7 +40,7 @@ protected function setUp(): void
         $this->filesystem->deleteDirectory($this->path, recursive: true);
         $this->filesystem->ensureDirectoryExists($this->path);
 
-        $this->container->get(Kernel::class)->internalStorage = realpath($this->path);
+        $this->container->get(FrameworkKernel::class)->internalStorage = realpath($this->path);
 
         $this->container->config(new SessionConfig(path: 'sessions'));
         $this->container->singleton(

tests/Integration/Http/FileSessionTest.php

@@ -5,6 +5,7 @@
 namespace Tests\Tempest\Integration\Http;
 
 use Tempest\Clock\Clock;
+use Tempest\Core\FrameworkKernel;
 use Tempest\Core\Kernel;
 use Tempest\Filesystem\LocalFilesystem;
 use Tempest\Router\Session\Managers\FileSessionManager;
@@ -22,6 +23,7 @@
 final class FileSessionTest extends FrameworkIntegrationTestCase
 {
     private string $path = __DIR__ . '/Fixtures/tmp';
+
     private LocalFilesystem $filesystem;
 
     protected function setUp(): void
@@ -31,9 +33,10 @@ protected function setUp(): void
         $this->filesystem = new LocalFilesystem();
         $this->filesystem->deleteDirectory($this->path, recursive: true);
         $this->filesystem->ensureDirectoryExists($this->path);
+
         $this->path = realpath($this->path);
 
-        $this->container->get(Kernel::class)->internalStorage = realpath($this->path);
+        $this->container->get(FrameworkKernel::class)->internalStorage = realpath($this->path);
 
         $this->container->config(new SessionConfig(path: 'sessions'));
         $this->container->singleton(