fix: query param name collision in uri function (#679)

Author: brendt

composer.json

@@ -75,6 +75,7 @@
         "tempest/view": "self.version"
     },
     "minimum-stability": "dev",
+    "prefer-stable": true,
     "autoload": {
         "psr-4": {
             "Tempest\\Auth\\": "src/Tempest/Auth/src/",

src/Tempest/Http/src/GenericRouter.php

@@ -129,7 +129,7 @@ public function toUri(array|string $action, ...$params): string
 
 
         foreach ($params as $key => $value) {
-            if (! str_contains($uri, "{$key}")) {
+            if (! str_contains($uri, sprintf('{%s', $key))) {
                 $queryParams[$key] = $value;
 
                 continue;

tests/Integration/Http/Static/StaticGenerateCommandTest.php

@@ -13,7 +13,7 @@
  */
 final class StaticGenerateCommandTest extends FrameworkIntegrationTestCase
 {
-    public function test_generate(): void
+    public function test_static_site_generate_command(): void
     {
         $appConfig = new AppConfig(baseUri: 'https://test.com');
         $this->container->config($appConfig);

tests/Integration/Route/RouterTest.php

@@ -88,6 +88,15 @@ public function test_generate_uri(): void
         $this->assertEquals('https://test.com/test/1/a/b/c/d', $router->toUri([TestController::class, 'withCustomRegexParams'], id: 1, name: 'a/b/c/d'));
     }
 
+    public function test_uri_generation_with_query_param(): void
+    {
+        $router = $this->container->get(GenericRouter::class);
+
+        $uri = $router->toUri(TestController::class, test: 'foo');
+
+        $this->assertSame('/test?test=foo', $uri);
+    }
+
     public function test_with_view(): void
     {
         $router = $this->container->get(GenericRouter::class);