Skip to content

Commit 5af66b9

Browse files
brendtbrendt
committed
wip
1 parent b4d24b7 commit 5af66b9

File tree

8 files changed

+29
-29
lines changed

8 files changed

+29
-29
lines changed

‎tests/Integration/Database/Builder/InsertQueryBuilderTest.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,8 @@ public function test_inserting_has_many_via_parent_model_throws_exception(): voi
169169
chapters: ['title' => 'Chapter 01'],
170170
)
171171
->build();
172-
} catch (HasManyRelationCouldNotBeInsterted $cannotInsertHasManyRelation) {
173-
$this->assertStringContainsString(Book::class . '::$chapters', $cannotInsertHasManyRelation->getMessage());
172+
} catch (HasManyRelationCouldNotBeInsterted $hasManyRelationCouldNotBeInsterted) {
173+
$this->assertStringContainsString(Book::class . '::$chapters', $hasManyRelationCouldNotBeInsterted->getMessage());
174174
}
175175
}
176176

@@ -183,8 +183,8 @@ public function test_inserting_has_one_via_parent_model_throws_exception(): void
183183
isbn: ['value' => '979-8344313764'],
184184
)
185185
->build();
186-
} catch (HasOneRelationCouldNotBeInserted $cannotInsertHasOneRelation) {
187-
$this->assertStringContainsString(Book::class . '::$isbn', $cannotInsertHasOneRelation->getMessage());
186+
} catch (HasOneRelationCouldNotBeInserted $hasOneRelationCouldNotBeInserted) {
187+
$this->assertStringContainsString(Book::class . '::$isbn', $hasOneRelationCouldNotBeInserted->getMessage());
188188
}
189189
}
190190

‎tests/Integration/Database/Builder/UpdateQueryBuilderTest.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -219,8 +219,8 @@ public function test_update_has_many_relation_via_parent_model_throws_exception(
219219
chapters: ['title' => 'Chapter 01'],
220220
)
221221
->build();
222-
} catch (HasManyRelationCouldNotBeUpdated $cannotUpdateHasManyRelation) {
223-
$this->assertStringContainsString(Book::class . '::$chapters', $cannotUpdateHasManyRelation->getMessage());
222+
} catch (HasManyRelationCouldNotBeUpdated $hasManyRelationCouldNotBeUpdated) {
223+
$this->assertStringContainsString(Book::class . '::$chapters', $hasManyRelationCouldNotBeUpdated->getMessage());
224224
}
225225
}
226226

@@ -233,8 +233,8 @@ public function test_update_has_one_relation_via_parent_model_throws_exception()
233233
isbn: ['value' => '979-8344313764'],
234234
)
235235
->build();
236-
} catch (HasOneRelationCouldNotBeUpdated $cannotUpdateHasOneRelation) {
237-
$this->assertStringContainsString(Book::class . '::$isbn', $cannotUpdateHasOneRelation->getMessage());
236+
} catch (HasOneRelationCouldNotBeUpdated $hasOneRelationCouldNotBeUpdated) {
237+
$this->assertStringContainsString(Book::class . '::$isbn', $hasOneRelationCouldNotBeUpdated->getMessage());
238238
}
239239
}
240240

‎tests/Integration/Database/MultiDatabaseTest.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,8 @@ public function test_fails_with_unknown_connection(): void
159159

160160
try {
161161
$migrationManager->onDatabase('unknown')->executeUp(new CreateMigrationsTable());
162-
} catch (TaggedDependencyCouldNotBeResolved $cannotResolveTaggedDependency) {
163-
$this->assertStringContainsString('Could not resolve tagged dependency Tempest\Database\Config\DatabaseConfig#unknown', $cannotResolveTaggedDependency->getMessage());
162+
} catch (TaggedDependencyCouldNotBeResolved $taggedDependencyCouldNotBeResolved) {
163+
$this->assertStringContainsString('Could not resolve tagged dependency Tempest\Database\Config\DatabaseConfig#unknown', $taggedDependencyCouldNotBeResolved->getMessage());
164164
}
165165
}
166166

‎tests/Integration/Database/QueryStatements/AlterTableStatementTest.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,15 @@ public function test_it_can_alter_a_table_definition(): void
4444
name: 'Test',
4545
email: '[email protected]',
4646
);
47-
} catch (QueryWasInvalid $queryException) {
47+
} catch (QueryWasInvalid $queryWasInvalid) {
4848
$message = match ($this->container->get(DatabaseConfig::class)?->dialect) {
4949
DatabaseDialect::MYSQL => "Unknown column 'email'",
5050
DatabaseDialect::SQLITE => 'table users has no column named email',
5151
DatabaseDialect::POSTGRESQL => 'column "email" of relation "users" does not exist',
5252
null => throw new RuntimeException('No database dialect available'),
5353
};
5454

55-
$this->assertStringContainsString($message, $queryException->getMessage());
55+
$this->assertStringContainsString($message, $queryWasInvalid->getMessage());
5656
}
5757

5858
$this->migrate($migration::class);

‎tests/Integration/Mapper/MapperTest.php‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -155,18 +155,18 @@ public function test_make_object_with_missing_values_throws_exception_for_strict
155155
{
156156
try {
157157
make(ObjectWithStrictProperty::class)->from([]);
158-
} catch (MappingValuesWereMissing $missingValuesException) {
159-
$this->assertStringContainsString(': a', $missingValuesException->getMessage());
160-
$this->assertStringNotContainsString(': a, b', $missingValuesException->getMessage());
158+
} catch (MappingValuesWereMissing $mappingValuesWereMissing) {
159+
$this->assertStringContainsString(': a', $mappingValuesWereMissing->getMessage());
160+
$this->assertStringNotContainsString(': a, b', $mappingValuesWereMissing->getMessage());
161161
}
162162
}
163163

164164
public function test_make_object_with_missing_values_throws_exception_for_strict_class(): void
165165
{
166166
try {
167167
make(ObjectWithStrictOnClass::class)->from([]);
168-
} catch (MappingValuesWereMissing $missingValuesException) {
169-
$this->assertStringContainsString(': a, b', $missingValuesException->getMessage());
168+
} catch (MappingValuesWereMissing $mappingValuesWereMissing) {
169+
$this->assertStringContainsString(': a, b', $mappingValuesWereMissing->getMessage());
170170
}
171171
}
172172

‎tests/Integration/ORM/IsDatabaseModelTest.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -607,10 +607,10 @@ public function test_skipped_validation(): void
607607
index: -1,
608608
skip: -1,
609609
);
610-
} catch (ValidationFailed $validationException) {
611-
$this->assertStringContainsString('index', $validationException->getMessage());
612-
$this->assertStringContainsString(ModelWithValidation::class, $validationException->getMessage());
613-
$this->assertStringNotContainsString('skip', $validationException->getMessage());
610+
} catch (ValidationFailed $validationFailed) {
611+
$this->assertStringContainsString('index', $validationFailed->getMessage());
612+
$this->assertStringContainsString(ModelWithValidation::class, $validationFailed->getMessage());
613+
$this->assertStringNotContainsString('skip', $validationFailed->getMessage());
614614
}
615615
}
616616
}

‎tests/Integration/Route/RequestToObjectMapperTest.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ public function test_request(): void
2828

2929
try {
3030
map($request)->to(RequestObjectA::class);
31-
} catch (ValidationFailed $validationException) {
32-
$this->assertInstanceOf(NotNull::class, $validationException->failingRules['b'][0]);
31+
} catch (ValidationFailed $validationFailed) {
32+
$this->assertInstanceOf(NotNull::class, $validationFailed->failingRules['b'][0]);
3333
}
3434
}
3535

@@ -105,8 +105,8 @@ public function test_validation_fails_for_enum(): void
105105
))->with(
106106
RequestToObjectMapper::class,
107107
)->to(RequestWithEnum::class);
108-
} catch (ValidationFailed $validationException) {
109-
$this->assertArrayHasKey('enumParam', $validationException->failingRules);
108+
} catch (ValidationFailed $validationFailed) {
109+
$this->assertArrayHasKey('enumParam', $validationFailed->failingRules);
110110
}
111111
}
112112
}

‎tests/Integration/View/ViewComponentDiscoveryTest.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ public function test_duplicates(): void
2424
try {
2525
$discovery->discoverPath(new DiscoveryLocation('', ''), __DIR__ . '/duplicateComponent.view.php');
2626
$discovery->apply();
27-
} catch (ViewComponentWasAlreadyRegistered $duplicateViewComponent) {
28-
$this->assertStringContainsString(__DIR__ . '/duplicateComponent.view.php', $duplicateViewComponent->getMessage());
29-
$this->assertStringContainsString(Input::class, $duplicateViewComponent->getMessage());
30-
$this->assertStringContainsString('x-input', $duplicateViewComponent->getMessage());
27+
} catch (ViewComponentWasAlreadyRegistered $viewComponentWasAlreadyRegistered) {
28+
$this->assertStringContainsString(__DIR__ . '/duplicateComponent.view.php', $viewComponentWasAlreadyRegistered->getMessage());
29+
$this->assertStringContainsString(Input::class, $viewComponentWasAlreadyRegistered->getMessage());
30+
$this->assertStringContainsString('x-input', $viewComponentWasAlreadyRegistered->getMessage());
3131
}
3232
}
3333

0 commit comments

Comments
 (0)