fix: add event support to translator

Author: innocenzi

packages/intl/src/Catalog/CatalogInitializer.php

@@ -4,6 +4,7 @@
 
 use Tempest\Container\Container;
 use Tempest\Container\Initializer;
+use Tempest\Container\Singleton;
 use Tempest\Intl\IntlConfig;
 use Tempest\Intl\Locale;
 use Tempest\Support\Arr;
@@ -12,6 +13,7 @@
 
 final class CatalogInitializer implements Initializer
 {
+    #[Singleton]
     public function initialize(Container $container): Catalog
     {
         $config = $container->get(IntlConfig::class);

packages/intl/src/GenericTranslator.php

@@ -12,7 +12,7 @@
 {
     public function __construct(
         private IntlConfig $config,
-        private Catalog $catalog,
+        private(set) Catalog $catalog,
         private MessageFormatter $formatter,
         private ?EventBus $eventBus = null,
     ) {}

packages/intl/src/MessageFormatterInitializer.php

@@ -4,11 +4,13 @@
 
 use Tempest\Container\Container;
 use Tempest\Container\Initializer;
+use Tempest\Container\Singleton;
 use Tempest\Intl\MessageFormat\Formatter\MessageFormatter;
 use Tempest\Intl\PluralRules\PluralRulesMatcher;
 
 final class MessageFormatterInitializer implements Initializer
 {
+    #[Singleton]
     public function initialize(Container $container): mixed
     {
         $config = $container->get(IntlConfig::class);

packages/intl/src/TranslatorInitializer.php

@@ -4,18 +4,22 @@
 
 use Tempest\Container\Container;
 use Tempest\Container\Initializer;
+use Tempest\Container\Singleton;
+use Tempest\EventBus\EventBus;
 use Tempest\Intl\Catalog\Catalog;
 use Tempest\Intl\IntlConfig;
 use Tempest\Intl\MessageFormat\Formatter\MessageFormatter;
 
 final class TranslatorInitializer implements Initializer
 {
+    #[Singleton]
     public function initialize(Container $container): Translator
     {
         return new GenericTranslator(
             config: $container->get(IntlConfig::class),
             catalog: $container->get(Catalog::class),
             formatter: $container->get(MessageFormatter::class),
+            eventBus: $container->get(EventBus::class),
         );
     }
 }

tests/Integration/Intl/TranslatorTest.php

@@ -2,20 +2,17 @@
 
 namespace Tests\Tempest\Integration\Intl;
 
-use Tempest\Core\Commands\DiscoveryClearCommand;
-use Tempest\Core\DiscoveryCache;
-use Tempest\Core\FrameworkKernel;
-use Tempest\Core\Kernel\LoadDiscoveryClasses;
-use Tempest\Discovery\DiscoveryLocation;
+use Tempest\EventBus\EventBus;
 use Tempest\Intl\Catalog\Catalog;
 use Tempest\Intl\IntlConfig;
 use Tempest\Intl\Locale;
+use Tempest\Intl\TranslationFailure;
+use Tempest\Intl\TranslationMiss;
 use Tempest\Intl\Translator;
 use Tests\Tempest\Integration\FrameworkIntegrationTestCase;
 
 use function Tempest\Intl\translate;
 use function Tempest\Intl\translate_locale;
-use function Tempest\Support\Path\normalize;
 
 final class TranslatorTest extends FrameworkIntegrationTestCase
 {
@@ -50,4 +47,44 @@ public function test_default_locale(): void
 
         $this->assertSame(Locale::default(), $config->currentLocale);
     }
+
+    public function test_event_miss(): void
+    {
+        /** @var TranslationMiss|null $received */
+        $received = null;
+
+        $eventbus = $this->container->get(EventBus::class);
+        $eventbus->listen(TranslationMiss::class, function (TranslationMiss $event) use (&$received): void {
+            $received = $event;
+        });
+
+        $translator = $this->container->get(Translator::class);
+        $translator->translate('unknown');
+
+        $this->assertInstanceOf(TranslationMiss::class, $received);
+        $this->assertSame(Locale::ENGLISH_UNITED_STATES, $received->locale);
+        $this->assertSame('unknown', $received->key);
+    }
+
+    public function test_event_fail(): void
+    {
+        /** @var TranslationFailure|null $received */
+        $received = null;
+
+        $eventbus = $this->container->get(EventBus::class);
+        $eventbus->listen(TranslationFailure::class, function (TranslationFailure $event) use (&$received): void {
+            $received = $event;
+        });
+
+        $catalog = $this->container->get(Catalog::class);
+        $catalog->add(Locale::ENGLISH_UNITED_STATES, 'failure', '{$foo');
+
+        $translator = $this->container->get(Translator::class);
+        $translator->translate('failure');
+
+        $this->assertInstanceOf(TranslationFailure::class, $received);
+        $this->assertSame(Locale::ENGLISH_UNITED_STATES, $received->locale);
+        $this->assertSame('failure', $received->key);
+        $this->assertSame('Failed to parse message.', $received->exception->getMessage());
+    }
 }