Skip to content

Commit 6270f72

Browse files
committed
refactor: variadic parameter detection in ConsoleArgumentDefinition
1 parent 657da18 commit 6270f72

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

packages/console/src/Input/ConsoleArgumentDefinition.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public static function fromParameter(ParameterReflector $parameter): ConsoleArgu
3737
default: $default,
3838
hasDefault: $parameter->isDefaultValueAvailable(),
3939
position: $parameter->getPosition(),
40-
isVariadic: $type->isVariadic,
40+
isVariadic: $parameter->isVariadic(),
4141
description: $attribute?->description,
4242
aliases: $attribute->aliases ?? [],
4343
help: $attribute?->help,

packages/reflection/src/TypeReflector.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,12 @@
5353

5454
private bool $isNullable;
5555

56-
public bool $isVariadic;
57-
5856
public function __construct(
5957
private PHPReflector|PHPReflectionType|string $reflector,
6058
) {
6159
$this->definition = $this->resolveDefinition($this->reflector);
6260
$this->isNullable = $this->resolveIsNullable($this->reflector);
6361
$this->cleanDefinition = str_replace('?', '', $this->definition);
64-
$this->isVariadic = $this->reflector instanceof PHPReflectionParameter && $this->reflector->isVariadic();
6562
}
6663

6764
public function asClass(): ClassReflector

0 commit comments

Comments
 (0)