refactor(cache): several fixes and improvements for the cache package (#1760)

Co-authored-by: Enzo Innocenzi <[email protected]>

Author: xHeaven

packages/cache/src/Commands/CacheStatusCommand.php

@@ -38,7 +38,7 @@ public function __construct(
         public function __invoke(bool $internal = true): void
         {
             if (! $this->container instanceof GenericContainer) {
-                $this->console->error('Clearing caches is only available when using the default container.');
+                $this->console->error('Checking cache status is only available when using the default container.');
                 return;
             }
 

packages/cache/src/GenericCache.php

@@ -130,6 +130,13 @@ public function get(Stringable|string $key): mixed
 
     public function getMany(iterable $key): array
     {
+        if (! $this->enabled) {
+            return Arr\map_with_keys(
+                array: $key,
+                map: fn (string|Stringable $key) => yield (string) $key => null,
+            );
+        }
+
         return Arr\map_with_keys(
             array: $key,
             map: fn (string|Stringable $key) => yield (string) $key => $this->adapter->getItem((string) $key)->get(),

packages/cache/src/InternalCacheInsightsProvider.php

@@ -4,6 +4,7 @@
 
 use Tempest\Core\ConfigCache;
 use Tempest\Core\DiscoveryCache;
+use Tempest\Core\DiscoveryCacheStrategy;
 use Tempest\Core\Insight;
 use Tempest\Core\InsightsProvider;
 use Tempest\Icon\IconCache;
@@ -26,7 +27,11 @@ public function getInsights(): array
             'Discovery' => match ($this->discoveryCache->valid) {
                 false => new Insight('Invalid', Insight::ERROR),
                 true => match ($this->discoveryCache->enabled) {
-                    true => new Insight('Enabled', Insight::ERROR),
+                    true => match ($this->discoveryCache->strategy) {
+                        DiscoveryCacheStrategy::FULL => new Insight('Enabled', Insight::SUCCESS),
+                        DiscoveryCacheStrategy::PARTIAL => new Insight('Enabled (partial)', Insight::SUCCESS),
+                        default => null, // INVALID and NONE are handled
+                    },
                     false => new Insight('Disabled', Insight::WARNING),
                 },
             },

packages/cache/src/Testing/RestrictedCache.php

@@ -10,67 +10,73 @@
 use Tempest\Cache\Lock;
 use Tempest\DateTime\DateTimeInterface;
 use Tempest\DateTime\Duration;
+use UnitEnum;
 
 final class RestrictedCache implements Cache
 {
     public bool $enabled;
 
     public function __construct(
-        private ?string $tag = null,
+        private null|string|UnitEnum $tag = null,
     ) {}
 
+    private function resolveTag(): ?string
+    {
+        return $this->tag instanceof UnitEnum ? $this->tag->name : $this->tag;
+    }
+
     public function lock(Stringable|string $key, null|Duration|DateTimeInterface $expiration = null, null|Stringable|string $owner = null): Lock
     {
-        throw new CacheUsageWasForbidden($this->tag);
+        throw new CacheUsageWasForbidden($this->resolveTag());
     }
 
     public function has(Stringable|string $key): bool
     {
-        throw new CacheUsageWasForbidden($this->tag);
+        throw new CacheUsageWasForbidden($this->resolveTag());
     }
 
     public function put(Stringable|string $key, mixed $value, null|Duration|DateTimeInterface $expiration = null): CacheItemInterface
     {
-        throw new CacheUsageWasForbidden($this->tag);
+        throw new CacheUsageWasForbidden($this->resolveTag());
     }
 
     public function putMany(iterable $values, null|Duration|DateTimeInterface $expiration = null): array
     {
-        throw new CacheUsageWasForbidden($this->tag);
+        throw new CacheUsageWasForbidden($this->resolveTag());
     }
 
     public function increment(Stringable|string $key, int $by = 1): int
     {
-        throw new CacheUsageWasForbidden($this->tag);
+        throw new CacheUsageWasForbidden($this->resolveTag());
     }
 
     public function decrement(Stringable|string $key, int $by = 1): int
     {
-        throw new CacheUsageWasForbidden($this->tag);
+        throw new CacheUsageWasForbidden($this->resolveTag());
     }
 
     public function get(Stringable|string $key): mixed
     {
-        throw new CacheUsageWasForbidden($this->tag);
+        throw new CacheUsageWasForbidden($this->resolveTag());
     }
 
     public function getMany(iterable $key): array
     {
-        throw new CacheUsageWasForbidden($this->tag);
+        throw new CacheUsageWasForbidden($this->resolveTag());
     }
 
     public function resolve(Stringable|string $key, Closure $callback, null|Duration|DateTimeInterface $expiration = null, ?Duration $stale = null): mixed
     {
-        throw new CacheUsageWasForbidden($this->tag);
+        throw new CacheUsageWasForbidden($this->resolveTag());
     }
 
     public function remove(Stringable|string $key): void
     {
-        throw new CacheUsageWasForbidden($this->tag);
+        throw new CacheUsageWasForbidden($this->resolveTag());
     }
 
     public function clear(): void
     {
-        throw new CacheUsageWasForbidden($this->tag);
+        throw new CacheUsageWasForbidden($this->resolveTag());
     }
 }