feat(core): optionally run composer up after installers (#839)

Author: brendt

src/Tempest/Console/src/Initializers/InvocationExecutorInitializer.php

@@ -5,13 +5,13 @@
 namespace Tempest\Console\Initializers;
 
 use Tempest\Console\ConsoleApplication;
-use Tempest\Console\Scheduler\GenericShellExecutor;
-use Tempest\Console\Scheduler\NullShellExecutor;
-use Tempest\Console\ShellExecutor;
 use Tempest\Container\Container;
 use Tempest\Container\Initializer;
 use Tempest\Container\Singleton;
 use Tempest\Core\Application;
+use Tempest\Core\ShellExecutor;
+use Tempest\Core\ShellExecutors\GenericShellExecutor;
+use Tempest\Core\ShellExecutors\NullShellExecutor;
 
 final readonly class InvocationExecutorInitializer implements Initializer
 {

src/Tempest/Console/src/Initializers/SchedulerInitializer.php

@@ -10,11 +10,11 @@
 use Tempest\Console\Scheduler\GenericScheduler;
 use Tempest\Console\Scheduler\NullScheduler;
 use Tempest\Console\Scheduler\SchedulerConfig;
-use Tempest\Console\ShellExecutor;
 use Tempest\Container\Container;
 use Tempest\Container\Initializer;
 use Tempest\Container\Singleton;
 use Tempest\Core\Application;
+use Tempest\Core\ShellExecutor;
 
 final readonly class SchedulerInitializer implements Initializer
 {

src/Tempest/Console/src/Installers/ConsoleInstaller.php

@@ -5,13 +5,12 @@
 namespace Tempest\Console\Installers;
 
 use Tempest\Core\Installer;
-use Tempest\Core\PublishesFiles;
+use Tempest\Core\IsComponentInstaller;
 use function Tempest\root_path;
-use function Tempest\Support\str;
 
 final class ConsoleInstaller implements Installer
 {
-    use PublishesFiles;
+    use IsComponentInstaller;
 
     public function getName(): string
     {
@@ -32,45 +31,7 @@ public function install(): void
                 }
             },
         );
-    }
-
-    private function installMainNamespace(): void
-    {
-        if ($this->composer->mainNamespace !== null) {
-            return;
-        }
-
-        if (! $this->confirm('Tempest detected no main project namespace. Do you want to create it?', default: true)) {
-            return;
-        }
-
-        $appPath = root_path($this->ask('Which path do you wish to use as your main project directory?', default: 'app/'));
-
-        $defaultAppNamespace = str($appPath)
-            ->replaceStart(root_path(), '')
-            ->trim('/')
-            ->explode('/')
-            ->map(fn (string $part) => ucfirst($part))
-            ->implode('\\')
-            ->append('\\')
-            ->toString();
-
-        $appNamespace = str($this->ask('Which namespace do you wish to use?', default: $defaultAppNamespace))
-            ->trim('\\')
-            ->append('\\')
-            ->toString();
-
-        if (! is_dir($appPath)) {
-            mkdir($appPath, recursive: true);
-        }
-
-        $this->composer
-            ->addNamespace(
-                $appNamespace,
-                $appPath,
-            )
-            ->save();
 
-        $this->success("Project namespace created: {$appPath}");
+        $this->updateComposer();
     }
 }

src/Tempest/Console/src/Scheduler/GenericScheduler.php

@@ -7,7 +7,7 @@
 use DateTime;
 use Tempest\Console\Input\ConsoleArgumentBag;
 use Tempest\Console\Scheduler;
-use Tempest\Console\ShellExecutor;
+use Tempest\Core\ShellExecutor;
 use function Tempest\event;
 
 final readonly class GenericScheduler implements Scheduler

src/Tempest/Console/src/Scheduler/GenericShellExecutor.php

@@ -132,6 +132,16 @@ public function submit(int|string $input = ''): self
         return $this;
     }
 
+    public function confirm(): self
+    {
+        return $this->submit('yes');
+    }
+
+    public function deny(): self
+    {
+        return $this->submit('no');
+    }
+
     public function print(): self
     {
         echo 'OUTPUT:' . PHP_EOL;

src/Tempest/Console/src/Scheduler/NullShellExecutor.php

@@ -19,8 +19,13 @@ final class Composer
     private array $composer;
 
     public function __construct(
-        private string $root,
+        private readonly string $root,
+        private ShellExecutor $executor,
     ) {
+    }
+
+    public function load(): self
+    {
         $this->composerPath = path($this->root, 'composer.json')->toString();
         $this->composer = $this->loadComposerFile($this->composerPath);
         $this->namespaces = arr($this->composer)
@@ -40,6 +45,8 @@ public function __construct(
         if (! isset($this->mainNamespace) && count($this->namespaces)) {
             $this->mainNamespace = $this->namespaces[0];
         }
+
+        return $this;
     }
 
     public function setMainNamespace(ComposerNamespace $namespace): self
@@ -49,6 +56,13 @@ public function setMainNamespace(ComposerNamespace $namespace): self
         return $this;
     }
 
+    public function setShellExecutor(ShellExecutor $executor): self
+    {
+        $this->executor = $executor;
+
+        return $this;
+    }
+
     public function addNamespace(string $namespace, string $path): self
     {
         $path = str_replace($this->root, '.', $path);
@@ -65,6 +79,13 @@ public function save(): self
         return $this;
     }
 
+    public function executeUpdate(): self
+    {
+        $this->executor->execute('composer up');
+
+        return $this;
+    }
+
     private function loadComposerFile(string $path): array
     {
         if (! file_exists($path)) {

src/Tempest/Console/src/ShellExecutor.php

@@ -0,0 +1,63 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tempest\Core;
+
+use function Tempest\root_path;
+use function Tempest\Support\str;
+
+/**
+ * @phpstan-require-implements \Tempest\Core\Installer
+ */
+trait IsComponentInstaller
+{
+    use PublishesFiles;
+
+    private function installMainNamespace(): void
+    {
+        if ($this->composer->mainNamespace !== null) {
+            return;
+        }
+
+        if (! $this->confirm('Tempest detected no main project namespace. Do you want to create it?', default: true)) {
+            return;
+        }
+
+        $appPath = root_path($this->ask('Which path do you wish to use as your main project directory?', default: 'app/'));
+
+        $defaultAppNamespace = str($appPath)
+            ->replaceStart(root_path(), '')
+            ->trim('/')
+            ->explode('/')
+            ->map(fn (string $part) => ucfirst($part))
+            ->implode('\\')
+            ->append('\\')
+            ->toString();
+
+        $appNamespace = str($this->ask('Which namespace do you wish to use?', default: $defaultAppNamespace))
+            ->trim('\\')
+            ->append('\\')
+            ->toString();
+
+        if (! is_dir($appPath)) {
+            mkdir($appPath, recursive: true);
+        }
+
+        $this->composer
+            ->addNamespace(
+                $appNamespace,
+                $appPath,
+            )
+            ->save();
+
+        $this->success("Project namespace created: {$appPath}");
+    }
+
+    private function updateComposer(): void
+    {
+        if ($this->confirm(question: 'Run composer update?', default: true)) {
+            $this->composer->executeUpdate();
+        }
+    }
+}