wip

Author: brendt

packages/core/src/DiscoveryConfig.php

@@ -7,9 +7,4 @@ final class DiscoveryConfig
     public function __construct(
         public array $skipDiscovery = [],
     ) {}
-
-    public function shouldBeSkipped(string $pathOrClassName): bool
-    {
-        return in_array($pathOrClassName, $this->skipDiscovery);
-    }
 }

packages/core/src/Kernel/LoadDiscoveryClasses.php

@@ -22,8 +22,6 @@
 use Tempest\Reflection\ClassReflector;
 use Throwable;
 
-use function Tempest\Support\Arr\contains;
-
 /** @internal */
 final class LoadDiscoveryClasses
 {
@@ -104,6 +102,7 @@ private function buildDiscovery(string $discoveryClass): Discovery
             /** @var SplFileInfo $file */
             foreach ($files as $file) {
                 $fileName = $file->getFilename();
+
                 if ($fileName === '') {
                     continue;
                 }
@@ -118,7 +117,7 @@ private function buildDiscovery(string $discoveryClass): Discovery
 
                 $input = $file->getPathname();
 
-                if ($this->discoveryConfig->shouldBeSkipped($input)) {
+                if ($this->shouldSkipBasedOnConfig($fileName)) {
                     continue;
                 }
 
@@ -139,6 +138,10 @@ private function buildDiscovery(string $discoveryClass): Discovery
                     }
                 }
 
+                if ($this->shouldSkipBasedOnConfig($input)) {
+                    continue;
+                }
+
                 if ($input instanceof ClassReflector) {
                     // If the input is a class, we'll call `discover`
                     if (! $this->shouldSkipDiscoveryForClass($discovery, $input)) {
@@ -168,15 +171,21 @@ private function applyDiscovery(Discovery $discovery): void
         $this->appliedDiscovery[$discovery::class] = true;
     }
 
+    private function shouldSkipBasedOnConfig(ClassReflector|string $input): bool
+    {
+        return false;
+        if ($input instanceof ClassReflector) {
+            $input = $input->getName();
+        }
+
+        return in_array($input, $this->discoveryConfig->skipDiscovery, strict: true);
+    }
+
     /**
      * Check whether discovery for a specific class should be skipped based on the #[SkipDiscovery] attribute
      */
     private function shouldSkipDiscoveryForClass(Discovery $discovery, ClassReflector $input): bool
     {
-        if ($this->discoveryConfig->shouldBeSkipped($input->getName())) {
-            return true;
-        }
-
         $attribute = $input->getAttribute(SkipDiscovery::class);
 
         if ($attribute === null) {