test(auth): cover instantiating GenericOAuthClient (#1590)

Co-authored-by: Enzo Innocenzi <[email protected]>

Author: brendt

packages/auth/src/OAuth/OAuthClientInitializer.php

@@ -4,11 +4,13 @@
 
 namespace Tempest\Auth\OAuth;
 
+use Tempest\Auth\Authentication\Authenticator;
 use Tempest\Auth\Exceptions\OAuthProviderWasMissing;
 use Tempest\Auth\Exceptions\OAuthWasNotConfigured;
 use Tempest\Container\Container;
 use Tempest\Container\DynamicInitializer;
 use Tempest\Container\Singleton;
+use Tempest\Http\Session\Session;
 use Tempest\Mapper\ObjectFactory;
 use Tempest\Reflection\ClassReflector;
 use Tempest\Router\UriGenerator;
@@ -38,6 +40,8 @@ public function initialize(ClassReflector $class, null|string|UnitEnum $tag, Con
             config: $config,
             uri: $container->get(UriGenerator::class),
             factory: $container->get(ObjectFactory::class),
+            session: $container->get(Session::class),
+            authenticator: $container->get(Authenticator::class),
         );
     }
 }

tests/Integration/Auth/OAuth/GenericOAuthClientTest.php

@@ -0,0 +1,34 @@
+<?php
+
+namespace Tests\Tempest\Integration\Auth\OAuth;
+
+use PHPUnit\Framework\Attributes\Test;
+use Tempest\Auth\Exceptions\OAuthWasNotConfigured;
+use Tempest\Auth\OAuth\Config\GitHubOAuthConfig;
+use Tempest\Auth\OAuth\GenericOAuthClient;
+use Tempest\Auth\OAuth\OAuthClient;
+use Tests\Tempest\Integration\FrameworkIntegrationTestCase;
+
+final class GenericOAuthClientTest extends FrameworkIntegrationTestCase
+{
+    #[Test]
+    public function creates_oauth_client(): void
+    {
+        $this->container->config(new GitHubOAuthConfig(
+            clientId: 'client-id',
+            clientSecret: 'client-secret', // @mago-expect lint:no-literal-password
+            redirectTo: '/oauth/callback',
+            scopes: ['user:email'],
+        ));
+
+        $this->assertInstanceOf(GenericOAuthClient::class, $this->container->get(OAuthClient::class));
+    }
+
+    #[Test]
+    public function throws_when_no_config(): void
+    {
+        $this->expectException(OAuthWasNotConfigured::class);
+
+        $this->container->get(OAuthClient::class);
+    }
+}