fix(database): handle object serialization using insert

Author: innocenzi

packages/database/src/Builder/QueryBuilders/InsertQueryBuilder.php

@@ -323,7 +323,7 @@ private function resolveIterableData(iterable $model): array
                 continue;
             }
 
-            $entry[$key] = $value;
+            $entry[$key] = $this->serializeIterableValue($key, $value);
         }
 
         return $entry;
@@ -447,4 +447,36 @@ private function serializeValue(PropertyReflector $property, mixed $value): mixe
 
         return $this->serializerFactory->forProperty($property)?->serialize($value) ?? $value;
     }
+
+    private function serializeIterableValue(string $key, mixed $value): mixed
+    {
+        if ($value === null) {
+            return null;
+        }
+
+        // Booleans should be handled by the database layer, not by serializers
+        if (is_bool($value)) {
+            return $value;
+        }
+
+        // Only serialize if we have an object model to work with
+        if (! $this->model->isObjectModel()) {
+            return $value;
+        }
+
+        if (! $this->model?->reflector->hasProperty($key)) {
+            return $value;
+        }
+
+        $property = $this->model->reflector->getProperty($key);
+
+        if ($property->getType()->accepts(PrimaryKey::class)) {
+            return $value;
+        }
+
+        return $this->serializeValue(
+            property: $property,
+            value: $value,
+        );
+    }
 }

tests/Integration/Database/Builder/InsertQueryBuilderTest.php

@@ -71,7 +71,7 @@ public function test_insert_on_model_table(): void
         $query = query(Author::class)
             ->insert(
                 $author,
-                ['name' => 'other name', 'type' => AuthorType::B->value, 'publisher_id' => null],
+                ['name' => 'other name', 'type' => AuthorType::B, 'publisher_id' => null],
             )
             ->build();
 

tests/Integration/Database/DtoSerialization/BasicDtoSerializationTest.php

@@ -56,6 +56,43 @@ public function down(): null
         $this->assertSame(80, $retrievedCharacter->stats->mana);
     }
 
+    public function test_simple_dto_serialization_with_named_arguments(): void
+    {
+        $this->migrate(CreateMigrationsTable::class, new class implements DatabaseMigration {
+            public string $name = '001_simple_character_named_args';
+
+            public function up(): QueryStatement
+            {
+                return new CreateTableStatement('characters')
+                    ->primary()
+                    ->text('name')
+                    ->json('stats');
+            }
+
+            public function down(): null
+            {
+                return null;
+            }
+        });
+
+        query(Character::class)
+            ->insert(
+                name: 'Fern',
+                stats: new CharacterStats(level: 25, health: 80, mana: 120),
+            )
+            ->execute();
+
+        $retrievedCharacter = query(Character::class)
+            ->select()
+            ->first();
+
+        $this->assertSame('Fern', $retrievedCharacter->name);
+        $this->assertInstanceOf(CharacterStats::class, $retrievedCharacter->stats);
+        $this->assertSame(25, $retrievedCharacter->stats->level);
+        $this->assertSame(80, $retrievedCharacter->stats->health);
+        $this->assertSame(120, $retrievedCharacter->stats->mana);
+    }
+
     public function test_dto_with_enums(): void
     {
         $this->migrate(CreateMigrationsTable::class, new class implements DatabaseMigration {