feat(support): support not specifying a value to ArrayHelper::pop and ArrayHelper::unshift (#692)

Co-authored-by: Brent Roose <[email protected]>

Author: innocenzi

src/Tempest/Support/src/ArrayHelper.php

@@ -431,7 +431,7 @@ public function last(?Closure $filter = null): mixed
      *
      * @param mixed $value The popped value will be stored in this variable
      */
-    public function pop(mixed &$value): self
+    public function pop(mixed &$value = null): self
     {
         $value = $this->last();
 
@@ -443,7 +443,7 @@ public function pop(mixed &$value): self
      *
      * @param mixed $value The unshifted value will be stored in this variable
      */
-    public function unshift(mixed &$value): self
+    public function unshift(mixed &$value = null): self
     {
         $value = $this->first();
 

src/Tempest/Support/tests/ArrayHelperTest.php

@@ -166,6 +166,12 @@ public function test_pop(): void
 
         $this->assertSame('c', $value);
         $this->assertTrue($array->equals(['a', 'b']));
+
+        $this->assertTrue(arr(['a', 'b', 'c'])->pop()->equals(['a', 'b']));
+        $this->assertTrue(arr()->pop()->isEmpty());
+
+        arr()->pop($value);
+        $this->assertNull($value);
     }
 
     public function test_unshift(): void
@@ -174,6 +180,12 @@ public function test_unshift(): void
 
         $this->assertSame('a', $value);
         $this->assertTrue($array->equals(['b', 'c']));
+
+        $this->assertTrue(arr(['a', 'b', 'c'])->unshift()->equals(['b', 'c']));
+        $this->assertTrue(arr()->unshift()->isEmpty());
+
+        arr()->unshift($value);
+        $this->assertNull($value);
     }
 
     public function test_last(): void