refactor(upgrade): use sets and set lists (#1557)

xHeaven · brendt · innocenzi · web-flow · commit 6bd1b4709962 · 2025-09-17T14:19:14.000+02:00
Co-authored-by: Brent Roose &lt;brendt@stitcher.io&gt;
Co-authored-by: Enzo Innocenzi &lt;enzo@innocenzi.dev&gt;
diff --git a/packages/upgrade/README.md b/packages/upgrade/README.md
@@ -9,7 +9,9 @@
 ```php
 return RectorConfig::configure()
     // …
-    ->withSets([__DIR__ . '/vendor/tempest/framework/packages/upgrade/src/tempest2.php']);
+    ->withSets([
+        TempestSetList::TEMPEST_20,
+    ]);
 ```
 
-3. Run `vendor/bin/rector`
+3. Run `vendor/bin/rector`
diff --git a/packages/upgrade/config/sets/level/up-to-tempest-20.php b/packages/upgrade/config/sets/level/up-to-tempest-20.php
@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Tempest\Upgrade\Set\TempestSetList;
+
+return static function (RectorConfig $config): void {
+    $config->sets([
+        TempestSetList::TEMPEST_20,
+    ]);
+};
diff --git a/packages/upgrade/config/sets/tempest20.php b/packages/upgrade/config/sets/tempest20.php
diff --git a/packages/upgrade/src/Set/TempestLevelSetList.php b/packages/upgrade/src/Set/TempestLevelSetList.php
@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tempest\Upgrade\Set;
+
+final class TempestLevelSetList
+{
+    public const string UP_TO_TEMPEST_20 = __DIR__ . '/../../config/sets/level/up-to-tempest-20.php';
+}
diff --git a/packages/upgrade/src/Set/TempestSetList.php b/packages/upgrade/src/Set/TempestSetList.php
@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tempest\Upgrade\Set;
+
+final class TempestSetList
+{
+    public const string TEMPEST_20 = __DIR__ . '/../../config/sets/tempest20.php';
+}
diff --git a/packages/upgrade/tests/Tempest20/Fixtures/IsCurrentUriNamespaceChange.input.php b/packages/upgrade/tests/Tempest20/Fixtures/IsCurrentUriNamespaceChange.input.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Tempest\Upgrade\Tests\Tempest2\Fixtures;
+namespace Tempest\Upgrade\Tests\Tempest20\Fixtures;
 
 use function Tempest\is_current_uri;
 
@@ -10,4 +10,4 @@ public function __invoke()
     {
         return is_current_uri(self::class);
     }
-}
+}
diff --git a/packages/upgrade/tests/Tempest20/Fixtures/MigrateUpAndDownMigration.input.php b/packages/upgrade/tests/Tempest20/Fixtures/MigrateUpAndDownMigration.input.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Tempest\Upgrade\Tests\Tempest2\Fixtures;
+namespace Tempest\Upgrade\Tests\Tempest20\Fixtures;
 
 use Tempest\Database\DatabaseMigration;
 use Tempest\Database\QueryStatement;
diff --git a/packages/upgrade/tests/Tempest20/Fixtures/MigrateUpMigration.expected.php b/packages/upgrade/tests/Tempest20/Fixtures/MigrateUpMigration.expected.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Tempest\Upgrade\Tests\Tempest2\Fixtures;
+namespace Tempest\Upgrade\Tests\Tempest20\Fixtures;
 
 use Tempest\Database\QueryStatement;
 use Tempest\Database\QueryStatements\CreateTableStatement;
diff --git a/packages/upgrade/tests/Tempest20/Fixtures/MigrateUpMigration.input.php b/packages/upgrade/tests/Tempest20/Fixtures/MigrateUpMigration.input.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Tempest\Upgrade\Tests\Tempest2\Fixtures;
+namespace Tempest\Upgrade\Tests\Tempest20\Fixtures;
 
 use Tempest\Database\DatabaseMigration;
 use Tempest\Database\QueryStatement;
diff --git a/packages/upgrade/tests/Tempest20/Fixtures/Model.input.php b/packages/upgrade/tests/Tempest20/Fixtures/Model.input.php
diff --git a/packages/upgrade/tests/Tempest20/Fixtures/UriNamespaceChange.input.php b/packages/upgrade/tests/Tempest20/Fixtures/UriNamespaceChange.input.php
diff --git a/packages/upgrade/tests/Tempest20/Tempest20RectorTest.php b/packages/upgrade/tests/Tempest20/Tempest20RectorTest.php
@@ -1,14 +1,14 @@
 <?php
 
-namespace Tempest\Upgrade\Tests\Tempest2;
+namespace Tempest\Upgrade\Tests\Tempest20;
 
 use PHPUnit\Framework\TestCase;
 use Tempest\Upgrade\Tests\RectorTester;
 
-final class Tempest2RectorTest extends TestCase
+final class Tempest20RectorTest extends TestCase
 {
     private RectorTester $rector {
-        get => new RectorTester(__DIR__ . '/tempest2_rector.php');
+        get => new RectorTester(__DIR__ . '/tempest20_rector.php');
     }
 
     public function test_migration_with_only_up(): void
diff --git a/packages/upgrade/tests/Tempest20/tempest20_rector.php b/packages/upgrade/tests/Tempest20/tempest20_rector.php
@@ -1,8 +1,9 @@
 <?php
 
 use Rector\Config\RectorConfig;
+use Tempest\Upgrade\Set\TempestSetList;
 
 return RectorConfig::configure()
     ->withSets([
-        __DIR__ . '/../../src/tempest2.php',
+        TempestSetList::TEMPEST_20,
     ]);

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`<?php`
`2`	`2`
`3`		`-namespace Tempest\Upgrade\Tests\Tempest2\Fixtures;`
	`3`	`+namespace Tempest\Upgrade\Tests\Tempest20\Fixtures;`
`4`	`4`
`5`	`5`	`use function Tempest\is_current_uri;`
`6`	`6`
`@@ -10,4 +10,4 @@ public function __invoke()`
`10`	`10`	`{`
`11`	`11`	`return is_current_uri(self::class);`
`12`	`12`	`}`
`13`		`-}`
	`13`	`+}`