fix(view): properly unset local view component variables (#1221)

Author: brendt

packages/view/src/Elements/PhpDataElement.php

@@ -32,7 +32,8 @@ public function compile(): string
 
         // We'll declare the variable in PHP right before the actual element
         $variableDeclaration = sprintf(
-            '$_%sIsLocal = isset($%s) === false; $%s ??= %s ?? null;',
+            '$_%sIsLocal = $_%sIsLocal ?? isset($%s) === false; $%s ??= %s ?? null;',
+            $localVariableName,
             $localVariableName,
             $localVariableName,
             $localVariableName,
@@ -44,7 +45,8 @@ public function compile(): string
         // And we'll remove it right after the element, this way we've created a "local scope"
         // where the variable is only available to that specific element.
         $variableRemoval = sprintf(
-            'if ($_%sIsLocal) { unset($%s); }',
+            'if ($_%sIsLocal ?? null) { unset($%s); }; unset($_%sIsLocal)',
+            $localVariableName,
             $localVariableName,
             $localVariableName,
         );

tests/Integration/View/ViewComponentTest.php

@@ -871,4 +871,21 @@ public function test_nested_slots_with_escaping(): void
 
         $this->assertSnippetsMatch('<a>testing</a>', $html);
     }
+
+    public function test_repeated_local_var_across_view_components(): void
+    {
+        $this->registerViewComponent('x-test', '<div :thing="$thing">{{ $thing }}</div>');
+
+        $html = $this->render(<<<'HTML'
+        <x-test thing="a" />
+        <x-test thing="b" />
+        <x-test thing="c" />
+        HTML);
+
+        $this->assertSnippetsMatch('
+            <div thing="a">a</div>
+            <div thing="b">b</div>
+            <div thing="c">c</div>
+        ', $html);
+    }
 }