feat(view): parse RSS feeds with tempest/view (#1617)

Author: brendt

packages/view/src/Parser/TempestViewLexer.php

@@ -29,6 +29,8 @@ public function lex(): TokenCollection
                 $tokens[] = $this->lexComment();
             } elseif ($this->comesNext('<!doctype') || $this->comesNext('<!DOCTYPE')) {
                 $tokens[] = $this->lexDocType();
+            } elseif ($this->comesNext('<![CDATA')) {
+                $tokens = [...$tokens, ...$this->lexCharacterData()];
             } elseif ($this->comesNext('<')) {
                 $tokens = [...$tokens, ...$this->lexTag()];
             } else {
@@ -192,4 +194,22 @@ private function lexDoctype(): Token
 
         return new Token($buffer, TokenType::DOCTYPE);
     }
+
+    private function lexCharacterData(): array
+    {
+        $tokens = [
+            new Token($this->consumeIncluding('<![CDATA['), TokenType::CHARACTER_DATA_OPEN),
+        ];
+
+        $buffer = '';
+
+        while ($this->seek(3) !== ']]>' && $this->current !== null) {
+            $buffer .= $this->consume();
+        }
+
+        $tokens[] = new Token($buffer, TokenType::CONTENT);
+        $tokens[] = new Token($this->consume(3), TokenType::CHARACTER_DATA_CLOSE);
+
+        return $tokens;
+    }
 }

packages/view/src/Parser/TokenType.php

@@ -15,4 +15,6 @@ enum TokenType
     case PHP;
     case CONTENT;
     case DOCTYPE;
+    case CHARACTER_DATA_OPEN;
+    case CHARACTER_DATA_CLOSE;
 }

packages/view/tests/TempestViewLexerTest.php

@@ -5,7 +5,6 @@
 use PHPUnit\Framework\Attributes\TestWith;
 use PHPUnit\Framework\TestCase;
 use Tempest\View\Parser\TempestViewLexer;
-use Tempest\View\Parser\TempestViewParser;
 use Tempest\View\Parser\Token;
 use Tempest\View\Parser\TokenCollection;
 use Tempest\View\Parser\TokenType;
@@ -280,6 +279,25 @@ public function test_unclosed_comment_tag(): void
         );
     }
 
+    public function test_cdata(): void
+    {
+        $tokens = new TempestViewLexer(<<<'RSS'
+        <title><![CDATA[ {{ $post['title'] }} ]]></title>
+        RSS)->lex();
+
+        $this->assertTokens(
+            expected: [
+                new Token('<title', TokenType::OPEN_TAG_START),
+                new Token('>', TokenType::OPEN_TAG_END),
+                new Token('<![CDATA[', TokenType::CHARACTER_DATA_OPEN),
+                new Token(' {{ $post[\'title\'] }} ', TokenType::CONTENT),
+                new Token(']]>', TokenType::CHARACTER_DATA_CLOSE),
+                new Token('</title>', TokenType::CLOSING_TAG),
+            ],
+            actual: $tokens,
+        );
+    }
+
     private function assertTokens(array $expected, TokenCollection $actual): void
     {
         $this->assertCount(count($expected), $actual);

tests/Integration/View/TempestViewRendererTest.php

@@ -782,4 +782,38 @@ class="block dark:bg-neutral-900 disabled:opacity-50 px-4 py-2.5 sm:py-3 border-
 
         $this->assertSnippetsMatch('<p>This should be rendered</p>', $html);
     }
+
+    public function test_parse_rss_feed(): void
+    {
+        $rss = <<<'XML'
+        <feed xmlns="http://www.w3.org/2005/Atom" xmlns:media="http://search.yahoo.com/mrss/">
+            <id>https://tempestphp.com/rss</id>
+            <link rel="self" type="application/atom+xml" href="https://tempestphp.com/rss" />
+            <title>Tempest</title>
+            <entry :foreach="$posts as $post">
+                <title><![CDATA[ {!! $post['title'] !!} ]]></title>
+                <media:content :url="$post['url']" medium="image" />
+            </entry>
+        </feed>
+        XML;
+
+        $parsed = $this->render($rss, posts: [
+            ['title' => '<h1>A</h1>', 'url' => 'https://tempestphp.com/a'],
+            ['title' => 'B', 'url' => 'https://tempestphp.com/b'],
+        ]);
+
+        $this->assertSnippetsMatch(<<<'RSS'
+        <feed xmlns="http://www.w3.org/2005/Atom" xmlns:media="http://search.yahoo.com/mrss/">
+            <id>https://tempestphp.com/rss</id>
+            <link rel="self" type="application/atom+xml" href="https://tempestphp.com/rss">
+            <title>Tempest</title>
+            <entry><title><![CDATA[ <h1>A</h1> ]]></title>
+                <media:content medium="image" url="https://tempestphp.com/a"></media:content>
+            </entry>
+            <entry><title><![CDATA[ B ]]></title>
+                <media:content medium="image" url="https://tempestphp.com/b"></media:content>
+            </entry>
+        </feed>
+        RSS, $parsed);
+    }
 }