refactor: clean up translator

Author: innocenzi

packages/intl/src/GenericTranslator.php

@@ -19,18 +19,16 @@ public function __construct(
 
     public function translateForLocale(Locale $locale, string $key, mixed ...$arguments): string
     {
-        $message = $this->catalog->get($locale, $key);
-
-        if (! $message) {
-            $message = $this->catalog->get($this->config->fallbackLocale, $key);
-        }
-
-        if (! $message) {
+        if (! $this->catalog->has($locale, $key)) {
             $this->eventBus?->dispatch(new TranslationMiss(
                 locale: $locale,
                 key: $key,
             ));
+        }
+
+        $message = $this->catalog->get($locale, $key) ?? $this->catalog->get($this->config->fallbackLocale, $key);
 
+        if ($message === null) {
             return $key;
         }
 

packages/intl/tests/FunctionsTest.php

@@ -4,7 +4,6 @@
 
 use PHPUnit\Framework\Attributes\RequiresPhpExtension;
 use PHPUnit\Framework\TestCase;
-use Tempest\Intl;
 use Tempest\Intl\Locale;
 use Tempest\Intl\Number;
 use Tempest\Support\Currency;

packages/support/src/Str/functions.php

@@ -813,7 +813,7 @@ function pad_left(string $string, int $totalLength, string $padString = ' '): st
      *      => 'Yeet'
      *
      *      pad_right('مرحبا', 8, 'ا')
-     *      => 'مرح��اااا'
+     *      => 'مرحباااا'
      *
      * @param non-empty-string $padString
      * @param int<0, max> $totalLength