refactor(support): minor code cleanup (#961)

Co-authored-by: Enzo Innocenzi <[email protected]>

Author: xHeaven

src/Tempest/Support/src/Arr/functions.php

@@ -445,7 +445,7 @@ function intersect_keys(iterable $array, array ...$arrays): array
      */
     function merge(iterable $array, iterable ...$arrays): array
     {
-        return array_merge(to_array($array), ...array_map(fn (iterable $value) => to_array($value), $arrays));
+        return array_merge(to_array($array), ...array_map(to_array(...), $arrays));
     }
 
     /**
@@ -456,7 +456,7 @@ function merge(iterable $array, iterable ...$arrays): array
      * @template TValue
      *
      * @param iterable<TKey,TValue> $array
-     * @param array<array-key, TCombineValue>|array<array-key, TCombineValue> $values
+     * @param iterable<array-key, TCombineValue> $values
      *
      * @return array<array-key, TCombineValue>
      */
@@ -580,7 +580,7 @@ function is_empty(iterable $array): bool
      */
     function implode(iterable $array, string $glue): ImmutableString
     {
-        return new ImmutableString(\implode($glue, $array));
+        return new ImmutableString(\implode($glue, to_array($array)));
     }
 
     /**

src/Tempest/Support/src/IsEnumHelper.php

@@ -10,9 +10,9 @@
 use Iterator;
 use IteratorAggregate;
 use Tempest\Support\Arr\ImmutableArray;
-use Traversable;
 use UnitEnum;
 use ValueError;
+use function Tempest\Support\Arr\to_array;
 
 /**
  * This trait provides a bunch of helper methods to work with enums
@@ -89,11 +89,11 @@ public function isNot(UnitEnum $enum): bool
     /**
      * Check if the current enum case is in the given list of enums
      *
-     * @param Traversable<UnitEnum>|array<UnitEnum> $enums The list of enums to check
+     * @param iterable<UnitEnum> $enums The list of enums to check
      *
      * @return bool True if the current enum is in the list, false otherwise
      */
-    public function in(Traversable|array $enums): bool
+    public function in(iterable $enums): bool
     {
         $iterator = match (true) {
             is_array($enums) => new ArrayIterator($enums),
@@ -102,23 +102,17 @@ public function in(Traversable|array $enums): bool
             default => throw new InvalidArgumentException(sprintf('The given value must be an iterable value, "%s" given', get_debug_type($enums))),
         };
 
-        foreach ($iterator as $enum) {
-            if ($this->is($enum)) {
-                return true;
-            }
-        }
-
-        return false;
-    }
+		return array_any(to_array($iterator), fn($enum) => $this->is($enum));
+	}
 
     /**
      * Check if the current enum case is not in the given list of enums
      *
-     * @param Traversable<UnitEnum>|array<UnitEnum> $enums The list of enums to check
+     * @param iterable<UnitEnum> $enums The list of enums to check
      *
      * @return bool True if the current enum is not in the list, false otherwise
      */
-    public function notIn(Traversable|array $enums): bool
+    public function notIn(iterable $enums): bool
     {
         return ! $this->in($enums);
     }

src/Tempest/Support/src/JavaScript/PackageManager.php

@@ -47,14 +47,9 @@ public function getInstallCommand(): string
 
     public static function detect(string $cwd): ?self
     {
-        foreach (PackageManager::cases() as $packageManager) {
-            foreach ($packageManager->getLockFiles() as $lockFile) {
-                if (file_exists($cwd . '/' . $lockFile)) {
-                    return $packageManager;
-                }
-            }
-        }
-
-        return null;
+        return array_find(
+            array: PackageManager::cases(),
+            callback: fn($packageManager) => array_any($packageManager->getLockFiles(), fn($lockFile) => file_exists($cwd . '/' . $lockFile))
+        );
     }
 }