Add attribute precedence

Author: brendt

src/Tempest/View/src/Elements/IsElement.php

@@ -32,7 +32,23 @@ public function getAttributes(): array
             $wrappingAttributes = [];
         }
 
-        return [...$this->attributes, ...$wrappingAttributes];
+        $attributes = [...$this->attributes, ...$wrappingAttributes];
+
+        // Some attributes should always come after others,
+        // so that these expressions have access to the data attributes
+        $attributePrecedence = [
+            ':foreach' => 1,
+            ':if' => 2,
+        ];
+
+        uksort($attributes, function (string $a, string $b) use ($attributePrecedence) {
+            $precedenceA = $attributePrecedence[$a] ?? 0;
+            $precedenceB = $attributePrecedence[$b] ?? 0;
+
+            return $precedenceA <=> $precedenceB;
+        });
+
+        return $attributes;
     }
 
     public function hasAttribute(string $name): bool

tests/Integration/View/TempestViewRendererTest.php

@@ -575,6 +575,35 @@ public function test_with_colon_symbol_in_html_tag(): void
         );
     }
 
+    public function test_loop_variable_can_be_used_within_the_looped_tag(): void
+    {
+        $html = $this->render(
+            view(
+                <<<'HTML'
+                    <a :foreach="$items as $item" :href="$item->uri">
+                        {{ $item->title }}
+                    </a>
+                HTML,
+            )
+                ->data(items: [
+                    new class {
+                        public string $title = 'Item 1';
+
+                        public string $uri = '/item-1';
+                    },
+                    new class {
+                        public string $title = 'Item 2';
+
+                        public string $uri = '/item-2';
+                    },
+                ]),
+        );
+
+        $this->assertSnippetsMatch(<<<'HTML'
+        <a href="/item-1">Item 1</a><a href="/item-2">Item 2</a>
+        HTML, $html);
+    }
+
     private function assertSnippetsMatch(string $expected, string $actual): void
     {
         $expected = str_replace([PHP_EOL, ' '], '', $expected);

tests/Integration/View/ViewComponentTest.php

@@ -791,42 +791,6 @@ public function test_nested_table_components(): void
         HTML, $html);
     }
 
-    public function test_loop_variable_can_be_used_within_the_looped_tag(): void
-    {
-        $this->registerViewComponent(
-            'x-some-component-with-loop',
-            <<<'HTML'
-            <a :foreach="$items as $item" :href="$item->uri">
-                {{ $item->title }}
-            </a>
-            HTML,
-        );
-
-        $html = $this->render(
-            view(
-                <<<'HTML'
-                    <x-some-component-with-loop :items="$this->items" />
-                HTML,
-            )
-                ->data(items: [
-                    new class {
-                        public string $title = 'Item 1';
-
-                        public string $uri = '/item-1';
-                    },
-                    new class {
-                        public string $title = 'Item 2';
-
-                        public string $uri = '/item-2';
-                    },
-                ]),
-        );
-
-        $this->assertSnippetsMatch(<<<'HTML'
-        <a href="/item-1">Item 1</a><a href="/item-2">Item 2</a>
-        HTML, $html);
-    }
-
     private function assertSnippetsMatch(string $expected, string $actual): void
     {
         $expected = str_replace([PHP_EOL, ' '], '', $expected);