test: remove flakyness from tests

Author: innocenzi

mago.toml

@@ -35,7 +35,6 @@ empty-line-after-opening-tag = false
 integrations = ["php-unit", "tempest"]
 
 [linter.rules]
-yoda-conditions = { enabled = false }
 interface-name = { psr = false }
 trait-name = { psr = false }
 class-name = { psr = false }
@@ -63,6 +62,3 @@ prefer-arrow-function = { enabled = false } # enable when references are fixed
 prefer-first-class-callable = { enabled = false } # enable when arguments are fixed
 strict-behavior = { allow-loose-behavior = true }
 yoda-conditions = { enabled = false }
-
-# [analyzer]
-# override-attribute = { enabled = false } # CONSIDER ENABLING

packages/cryptography/tests/TimelockTest.php

@@ -81,7 +81,7 @@ public function test_uses_clock_to_sleep(): void
 
         $elapsed = $clock->timestamp()->getMilliseconds() - $ms;
 
-        // Even if we mock the clock, there's a `microtime` call that may be off by a few ms on Windows
-        $this->assertEqualsToMoreOrLess(300, $elapsed, margin: 0, windowsMargin: 2);
+        // Even if we mock the clock, there's a `microtime` call that may be off by a few ms
+        $this->assertEqualsToMoreOrLess(300, $elapsed, margin: 2);
     }
 }

packages/support/tests/Random/FunctionsTest.php

@@ -96,7 +96,6 @@ public function test_is_ulid(): void
         $this->assertFalse(Random\is_ulid('0ec29141-3d58-4187-b664-2d93b7da0d31'));
         $this->assertFalse(Random\is_ulid('018dcc19-7e65-7c4b-9b14-9a11df3e0fdb'));
         $this->assertFalse(Random\is_ulid('foo'));
-        $this->assertFalse(Random\is_ulid(Random\secure_string(26)));
         $this->assertFalse(Random\is_ulid(null));
     }
 }

tests/Integration/Console/Components/TaskComponentTest.php

@@ -52,6 +52,8 @@ public function test_no_task(): void
 
     public function test_process_task(): void
     {
+        $this->skipCI('Flaky on CI');
+
         $this->console
             ->withoutPrompting()
             ->call(function (Console $console): void {
@@ -85,6 +87,8 @@ public function test_successful_task(): void
 
     public function test_failing_task(): void
     {
+        $this->skipCI('Flaky on CI');
+
         $this->console
             ->withoutPrompting()
             ->call(function (Console $console): void {