fix: missing migrations table when installing auth

Author: MohammadAlhallaq

packages/auth/src/Installer/AuthenticationInstaller.php

@@ -9,6 +9,8 @@
 use Tempest\Container\Container;
 use Tempest\Core\Installer;
 use Tempest\Core\PublishesFiles;
+use Tempest\Database\Database;
+use Tempest\Database\Migrations\CreateMigrationsTable;
 use Tempest\Database\Migrations\MigrationManager;
 
 use function Tempest\root_path;
@@ -36,6 +38,10 @@ public function install(): void
             $this->publishImports();
 
             if ($migration && $this->shouldMigrate()) {
+                if (! $this->migrationManager->doesMigrationsTableExist()) {
+                    $this->migrationManager->executeUp(new CreateMigrationsTable());
+                }
+
                 $this->migrationManager->executeUp(
                     migration: $this->container->get(to_fqcn($migration, root: root_path())),
                 );

packages/database/src/Migrations/MigrationManager.php

@@ -188,11 +188,6 @@ public function validate(): void
 
     public function executeUp(MigratesUp $migration): void
     {
-
-        if (! $migration instanceof CreateMigrationsTable) {
-            $this->ensureMigrationsTableExists();
-        }
-
         if ($migration instanceof ShouldMigrate && $migration->shouldMigrate($this->database) === false) {
             return;
         }
@@ -292,6 +287,23 @@ public function executeDown(MigratesDown $migration): void
         event(new MigrationRolledBack($migration->name));
     }
 
+    public function doesMigrationsTableExist(): bool
+    {
+        try {
+            Migration::select()
+                ->onDatabase($this->onDatabase)
+                ->limit(1)
+                ->all();
+        } catch (QueryWasInvalid $exception) {
+            if ($this->dialect->isTableNotFoundError($exception)) {
+                return false;
+            } else {
+                throw $exception;
+            }
+        }
+        return true;
+    }
+
     /**
      * @return \Tempest\Database\Migrations\TableMigrationDefinition[]
      */
@@ -339,20 +351,4 @@ private function getMinifiedSqlFromStatement(?QueryStatement $statement): string
 
         return $sql;
     }
-
-    private function ensureMigrationsTableExists(): void
-    {
-        try {
-            Migration::select()
-                ->onDatabase($this->onDatabase)
-                ->limit(1)
-                ->all();
-        } catch (QueryWasInvalid $exception) {
-            if ($this->dialect->isTableNotFoundError($exception)) {
-                $this->executeUp(new CreateMigrationsTable());
-            } else {
-                throw $exception;
-            }
-        }
-    }
 }