wip

Author: brendt

packages/router/src/Static/StaticGenerateCommand.php

@@ -62,10 +62,8 @@ public function __invoke(
         ?string $filter = null,
         #[ConsoleArgument(description: 'Crawl the site for dead links')]
         bool $crawl = false,
-        #[ConsoleArgument(description: 'Allow dead links, only works when the --crawl flag is set')]
-        bool $allowDeadLinks = false,
-        #[ConsoleArgument(description: 'Allow external dead links, only works when the --crawl flag is set')]
-        bool $allowExternalDeadLinks = true,
+        #[ConsoleArgument(description: 'Crawl external links, only works when the --crawl flag is set')]
+        bool $external = false,
         #[ConsoleArgument(aliases: ['v'])]
         bool $verbose = false,
     ): ExitCode {
@@ -155,9 +153,9 @@ public function __invoke(
                     }
 
                     if ($crawl) {
-                        $deadLinks = $this->detectDeadLinks($uri, $content, checkExternal: ! $allowExternalDeadLinks);
+                        $deadLinks = $this->detectDeadLinks($uri, $content, checkExternal: $external);
 
-                        if (! $allowDeadLinks && $deadLinks !== []) {
+                        if ($deadLinks !== []) {
                             $deadlinks[$uri] = $deadLinks;
                             throw new DeadLinksDetectedException($uri, $deadLinks);
                         }

tests/Integration/Http/Static/StaticGenerateCommandTest.php

@@ -112,7 +112,7 @@ public function test_dead_link_with_redirect(): void
         $this->container->config(new AppConfig(baseUri: 'https://test.com'));
 
         $this->console
-            ->call(StaticGenerateCommand::class, ['--crawl' => true, '--allow-external-dead-links' => false])
+            ->call(StaticGenerateCommand::class, ['--crawl' => true])
             ->assertExitCode(ExitCode::SUCCESS);
     }
 
@@ -124,7 +124,7 @@ public function test_allow_dead_links(): void
         $this->container->config(new AppConfig(baseUri: 'https://test.com'));
 
         $this->console
-            ->call(StaticGenerateCommand::class, ['--crawl' => true, '--allow-dead-links' => true])
+            ->call(StaticGenerateCommand::class, ['--crawl' => false])
             ->assertExitCode(ExitCode::SUCCESS);
     }
 
@@ -136,7 +136,7 @@ public function test_external_dead_links(): void
         $this->container->config(new AppConfig(baseUri: 'https://test.com'));
 
         $this->console
-            ->call(StaticGenerateCommand::class, ['--crawl' => true, '--allow-external-dead-links' => false])
+            ->call(StaticGenerateCommand::class, ['--crawl' => true, '--external' => true])
             ->assertSee('2 DEAD LINKS')
             ->assertSee('https://test.com/404')
             ->assertSee('https://google.com/404')