style: apply fixes from phpstan

Author: innocenzi

tests/Integration/Http/DatabaseSessionTest.php

@@ -7,7 +7,6 @@
 use PHPUnit\Framework\Attributes\PreCondition;
 use PHPUnit\Framework\Attributes\Test;
 use Tempest\Clock\Clock;
-use Tempest\Database\Database;
 use Tempest\Database\Migrations\CreateMigrationsTable;
 use Tempest\DateTime\Duration;
 use Tempest\Http\Session\Config\DatabaseSessionConfig;
@@ -30,7 +29,7 @@
  */
 final class DatabaseSessionTest extends FrameworkIntegrationTestCase
 {
-    private DatabaseSessionManager $manager {
+    private SessionManager $manager {
         get => $this->container->get(SessionManager::class);
     }
 
@@ -46,7 +45,6 @@ protected function configure(): void
         $this->container->singleton(SessionManager::class, fn () => new DatabaseSessionManager(
             $this->container->get(Clock::class),
             $this->container->get(SessionConfig::class),
-            $this->container->get(Database::class),
         ));
 
         $this->database->reset(migrate: false);

tests/Integration/Http/FileSessionTest.php

@@ -29,7 +29,7 @@ final class FileSessionTest extends FrameworkIntegrationTestCase
 {
     private string $path = __DIR__ . '/Fixtures/tmp';
 
-    private FileSessionManager $manager {
+    private SessionManager $manager {
         get => $this->container->get(SessionManager::class);
     }
 

tests/Integration/Http/FormSessionTest.php

@@ -7,6 +7,7 @@
 use PHPUnit\Framework\Attributes\Test;
 use Tempest\Http\Session\FormSession;
 use Tempest\Http\Session\Session;
+use Tempest\Validation\FailingRule;
 use Tempest\Validation\Rules\HasLength;
 use Tests\Tempest\Integration\FrameworkIntegrationTestCase;
 
@@ -27,8 +28,8 @@ final class FormSessionTest extends FrameworkIntegrationTestCase
     public function flash_errors_stores_errors(): void
     {
         $errors = [
-            'name' => [new HasLength(min: 3)],
-            'email' => [new HasLength(min: 5)],
+            'name' => [new FailingRule(new HasLength(min: 3))],
+            'email' => [new FailingRule(new HasLength(min: 5))],
         ];
 
         $this->formSession->setErrors($errors);
@@ -39,8 +40,8 @@ public function flash_errors_stores_errors(): void
     #[Test]
     public function errors_for_returns_field_specific_errors(): void
     {
-        $nameError = new HasLength(min: 3);
-        $emailError = new HasLength(min: 5);
+        $nameError = new FailingRule(new HasLength(min: 3));
+        $emailError = new FailingRule(new HasLength(min: 5));
 
         $this->formSession->setErrors([
             'name' => [$nameError],
@@ -55,7 +56,7 @@ public function errors_for_returns_field_specific_errors(): void
     public function errors_for_returns_empty_array_when_field_has_no_errors(): void
     {
         $this->formSession->setErrors([
-            'name' => [new HasLength(min: 3)],
+            'name' => [new FailingRule(new HasLength(min: 3))],
         ]);
 
         $this->assertEquals([], $this->formSession->getErrorsFor('email'));
@@ -65,7 +66,7 @@ public function errors_for_returns_empty_array_when_field_has_no_errors(): void
     public function has_errors_returns_true_when_errors_exist(): void
     {
         $this->formSession->setErrors([
-            'name' => [new HasLength(min: 3)],
+            'name' => [new FailingRule(new HasLength(min: 3))],
         ]);
 
         $this->assertTrue($this->formSession->hasErrors());
@@ -81,7 +82,7 @@ public function has_errors_returns_false_when_no_errors(): void
     public function has_error_returns_true_when_field_has_errors(): void
     {
         $this->formSession->setErrors([
-            'name' => [new HasLength(min: 3)],
+            'name' => [new FailingRule(new HasLength(min: 3))],
         ]);
 
         $this->assertTrue($this->formSession->hasError('name'));
@@ -91,7 +92,7 @@ public function has_error_returns_true_when_field_has_errors(): void
     public function has_error_returns_false_when_field_has_no_errors(): void
     {
         $this->formSession->setErrors([
-            'name' => [new HasLength(min: 3)],
+            'name' => [new FailingRule(new HasLength(min: 3))],
         ]);
 
         $this->assertFalse($this->formSession->hasError('email'));
@@ -143,7 +144,7 @@ public function value_returns_default_when_field_not_found(): void
     public function clear_removes_errors_and_values(): void
     {
         $this->formSession->setErrors([
-            'name' => [new HasLength(min: 3)],
+            'name' => [new FailingRule(new HasLength(min: 3))],
         ]);
         $this->formSession->setOriginalValues([
             'name' => 'John',
@@ -159,7 +160,7 @@ public function clear_removes_errors_and_values(): void
     public function errors_are_flashed_and_cleared_after_next_request(): void
     {
         $this->formSession->setErrors([
-            'name' => [new HasLength(min: 3)],
+            'name' => [new FailingRule(new HasLength(min: 3))],
         ]);
 
         // First access - errors exist

tests/Integration/Http/RedisSessionTest.php

@@ -28,7 +28,7 @@
  */
 final class RedisSessionTest extends FrameworkIntegrationTestCase
 {
-    private RedisSessionManager $manager {
+    private SessionManager $manager {
         get => $this->container->get(SessionManager::class);
     }
 
@@ -47,7 +47,7 @@ protected function configure(): void
         $this->container->singleton(SessionManager::class, fn () => new RedisSessionManager(
             clock: $this->container->get(Clock::class),
             redis: $this->container->get(Redis::class),
-            config: $this->container->get(SessionConfig::class),
+            config: $this->container->get(RedisSessionConfig::class),
         ));
 
         try {

tests/Integration/View/Components/InputComponentTest.php

@@ -3,6 +3,7 @@
 namespace Tests\Tempest\Integration\View\Components;
 
 use Tempest\Http\Session\FormSession;
+use Tempest\Validation\FailingRule;
 use Tempest\Validation\Rules\HasLength;
 use Tempest\Validation\Rules\IsInteger;
 use Tempest\Validation\Rules\IsString;
@@ -77,11 +78,11 @@ public function test_error_message(): void
     {
         $failingRules = [
             'name' => [
-                new IsString(),
-                new HasLength(min: 5),
+                new FailingRule(new IsString()),
+                new FailingRule(new HasLength(min: 5)),
             ],
             'other' => [
-                new IsInteger(),
+                new FailingRule(new IsInteger()),
             ],
         ];
 

tests/Integration/View/ViewComponentTest.php

@@ -9,6 +9,7 @@
 use Tempest\Core\AppConfig;
 use Tempest\Core\Environment;
 use Tempest\Http\Session\FormSession;
+use Tempest\Validation\FailingRule;
 use Tempest\Validation\Rules\IsAlphaNumeric;
 use Tempest\Validation\Rules\IsBetween;
 use Tempest\Validation\Validator;
@@ -215,8 +216,8 @@ public function test_component_with_anther_component_included_with_slot(): void
 
     public function test_view_component_with_injected_view(): void
     {
-        $between = new IsBetween(min: 1, max: 10);
-        $alphaNumeric = new IsAlphaNumeric();
+        $between = new FailingRule(new IsBetween(min: 1, max: 10));
+        $alphaNumeric = new FailingRule(new IsAlphaNumeric());
 
         $formSession = $this->container->get(FormSession::class);
         $formSession->setErrors(