refactor(core): various core package improvements and fixes (#1763)

Author: xHeaven

packages/core/src/FrameworkKernel.php

@@ -256,14 +256,16 @@ public function registerExceptionHandler(): self
         $handler = $this->container->get(ExceptionHandler::class);
 
         set_exception_handler($handler->handle(...));
-        set_error_handler(fn (int $code, string $message, string $filename, int $line) => $handler->handle(
-            new ErrorException(
+        set_error_handler(function (int $code, string $message, string $filename, int $line) use ($handler): bool {
+            $handler->handle(new ErrorException(
                 message: $message,
                 code: $code,
                 filename: $filename,
                 line: $line,
-            ),
-        ), error_levels: E_ERROR);
+            ));
+
+            return true;
+        }, error_levels: E_ERROR);
 
         return $this;
     }

packages/core/src/Kernel.php

@@ -36,6 +36,7 @@ public static function boot(
         string $root,
         array $discoveryLocations = [],
         ?Container $container = null,
+        ?string $internalStorage = null,
     ): self;
 
     public function shutdown(int|string $status = ''): never;

packages/core/src/Kernel/LoadConfig.php

@@ -100,7 +100,12 @@ private function scan(string $path, MutableArray $configPaths): void
                 return;
             }
 
-            foreach (scandir($input, SCANDIR_SORT_NONE) as $subPath) {
+            $subPaths = scandir($input, SCANDIR_SORT_NONE);
+            if ($subPaths === false) {
+                return;
+            }
+
+            foreach ($subPaths as $subPath) {
                 // `.` and `..` are skipped
                 if ($subPath === '.' || $subPath === '..') {
                     continue;

packages/core/src/Kernel/LoadDiscoveryClasses.php

@@ -153,7 +153,12 @@ private function scan(DiscoveryLocation $location, array $discoveries, string $p
                 return;
             }
 
-            foreach (scandir($input, SCANDIR_SORT_NONE) as $subPath) {
+            $subPaths = scandir($input, SCANDIR_SORT_NONE);
+            if ($subPaths === false) {
+                return;
+            }
+
+            foreach ($subPaths as $subPath) {
                 // `.` and `..` are skipped
                 if ($subPath === '.' || $subPath === '..') {
                     continue;

tests/Integration/Http/HttpExceptionHandlerTest.php

@@ -56,9 +56,9 @@ public function __construct(FrameworkKernel $kernel)
                     $this->container = $kernel->container;
                 }
 
-                public static function boot(string $root, array $discoveryLocations = [], ?Container $container = null): self
+                public static function boot(string $root, array $discoveryLocations = [], ?Container $container = null, ?string $internalStorage = null): self
                 {
-                    return Kernel::boot($root, $discoveryLocations, $container); // @phpstan-ignore-line
+                    return Kernel::boot($root, $discoveryLocations, $container, $internalStorage); // @phpstan-ignore-line
                 }
 
                 public function shutdown(int|string $status = ''): never