Removes useless alias

Author: erikaraujo

composer.json

@@ -34,7 +34,7 @@
         "symfony/uid": "^7.1",
         "symfony/var-dumper": "^7.1",
         "symfony/var-exporter": "^7.1",
-        "tempest/highlight": "^2.11.2",
+        "tempest/highlight": "^2.11.4",
         "vlucas/phpdotenv": "^5.6",
         "voku/portable-ascii": "^2.0.3"
     },

src/Tempest/Database/src/Builder/QueryBuilders/CountQueryBuilder.php

@@ -40,14 +40,6 @@ public function execute(mixed ...$bindings): int
         return $this->build()->fetchFirst(...$bindings)[$this->count->getKey()];
     }
 
-    /** @return self<TModelClass> */
-    public function as(string $alias): self
-    {
-        $this->count->alias = $alias;
-
-        return $this;
-    }
-
     /** @return self<TModelClass> */
     public function distinct(): self
     {

src/Tempest/Database/src/QueryStatements/CountStatement.php

@@ -11,8 +11,6 @@
 
 final class CountStatement implements QueryStatement
 {
-    public ?string $alias = null;
-
     public bool $distinct = false;
 
     public function __construct(
@@ -25,9 +23,8 @@ public function compile(DatabaseDialect $dialect): string
     {
         $query = arr([
             sprintf(
-                'SELECT COUNT(%s)%s',
+                'SELECT COUNT(%s)',
                 $this->getCountArgument(),
-                $this->alias ? " AS `{$this->alias}`" : '',
             ),
             sprintf('FROM `%s`', $this->table->name),
         ]);
@@ -54,10 +51,6 @@ public function getCountArgument(): string
 
     public function getKey(): string
     {
-        if ($this->alias !== null) {
-            return $this->alias;
-        }
-
         return "COUNT({$this->getCountArgument()})";
     }
 }

src/Tempest/Database/tests/QueryStatements/CountStatementTest.php

@@ -3,18 +3,9 @@
 namespace Tempest\Database\Tests\QueryStatements;
 
 use PHPUnit\Framework\TestCase;
-use Tempest\Database\Builder\FieldDefinition;
 use Tempest\Database\Builder\TableDefinition;
 use Tempest\Database\Config\DatabaseDialect;
 use Tempest\Database\QueryStatements\CountStatement;
-use Tempest\Database\QueryStatements\GroupByStatement;
-use Tempest\Database\QueryStatements\HavingStatement;
-use Tempest\Database\QueryStatements\JoinStatement;
-use Tempest\Database\QueryStatements\OrderByStatement;
-use Tempest\Database\QueryStatements\SelectStatement;
-use Tempest\Database\QueryStatements\WhereStatement;
-
-use function Tempest\Support\arr;
 
 final class CountStatementTest extends TestCase
 {
@@ -37,19 +28,17 @@ public function test_count_statement(): void
         $this->assertSame($expected, $statement->compile(DatabaseDialect::SQLITE));
     }
 
-    public function test_count_statement_with_alias(): void
+    public function test_count_statement_with_specified_column(): void
     {
         $tableDefinition = new TableDefinition('foo', 'bar');
 
         $statement = new CountStatement(
             table: $tableDefinition,
-            column: null,
+            column: 'foobar',
         );
 
-        $statement->alias = 'foobar';
-
         $expected = <<<SQL
-        SELECT COUNT(*) AS `foobar`
+        SELECT COUNT(`foobar`)
         FROM `foo`
         SQL;
 
@@ -58,7 +47,7 @@ public function test_count_statement_with_alias(): void
         $this->assertSame($expected, $statement->compile(DatabaseDialect::SQLITE));
     }
 
-    public function test_count_statement_with_specified_column(): void
+    public function test_count_statement_with_distinct_specified_column(): void
     {
         $tableDefinition = new TableDefinition('foo', 'bar');
 
@@ -67,8 +56,10 @@ public function test_count_statement_with_specified_column(): void
             column: 'foobar',
         );
 
+        $statement->distinct = true;
+
         $expected = <<<SQL
-        SELECT COUNT(`foobar`)
+        SELECT COUNT(DISTINCT `foobar`)
         FROM `foo`
         SQL;
 

tests/Integration/Database/Builder/CountQueryBuilderTest.php

@@ -40,31 +40,6 @@ public function test_simple_count_query(): void
         $this->assertSame(['Timeline Taxi', '1', '2025-01-01'], $bindings);
     }
 
-    public function test_count_query_with_alias(): void
-    {
-        $query = query('chapters')
-            ->count()
-            ->as('total')
-            ->where('`title` = ?', 'Timeline Taxi')
-            ->andWhere('`index` <> ?', '1')
-            ->orWhere('`createdAt` > ?', '2025-01-01')
-            ->build();
-
-        $expected = <<<SQL
-        SELECT COUNT(*) AS `total`
-        FROM `chapters`
-        WHERE `title` = ?
-        AND `index` <> ?
-        OR `createdAt` > ?
-        SQL;
-
-        $sql = $query->getSql();
-        $bindings = $query->bindings;
-
-        $this->assertSame($expected, $sql);
-        $this->assertSame(['Timeline Taxi', '1', '2025-01-01'], $bindings);
-    }
-
     public function test_count_query_with_specified_asterisk(): void
     {
         $query = query('chapters')
@@ -95,23 +70,6 @@ public function test_count_query_with_specified_field(): void
         $this->assertSame($expected, $sql);
     }
 
-    public function test_count_query_with_specified_field_and_alias(): void
-    {
-        $query = query('chapters')
-            ->count('title')
-            ->as('total')
-            ->build();
-
-        $sql = $query->getSql();
-
-        $expected = <<<SQL
-        SELECT COUNT(`title`) AS `total`
-        FROM `chapters`
-        SQL;
-
-        $this->assertSame($expected, $sql);
-    }
-
     public function test_count_query_without_specifying_column_cannot_be_distinct(): void
     {
         $this->expectException(CannotCountDistinctWithoutSpecifyingAColumn::class);
@@ -149,24 +107,6 @@ public function test_count_query_with_distinct_specified_field(): void
         $this->assertSame($expected, $sql);
     }
 
-    public function test_count_query_with_distinct_specified_field_and_alias(): void
-    {
-        $query = query('chapters')
-            ->count('title')
-            ->as('total')
-            ->distinct()
-            ->build();
-
-        $sql = $query->getSql();
-
-        $expected = <<<SQL
-        SELECT COUNT(DISTINCT `title`) AS `total`
-        FROM `chapters`
-        SQL;
-
-        $this->assertSame($expected, $sql);
-    }
-
     public function test_count_from_model(): void
     {
         $query = query(Author::class)->count()->build();