style: apply fixes from mago

Author: innocenzi

packages/i18n/bin/plural-rules.php

@@ -203,7 +203,7 @@ private function parseRule(string $rule): string
         // Extract the rule condition (before @integer/@decimal examples)
         $rulePart = trim(explode('@', $rule)[0]);
 
-        if (empty($rulePart)) {
+        if (! $rulePart) {
             return '';
         }
 
@@ -299,7 +299,7 @@ private function parseValueCondition(string $varExpression, string $operator, st
                 }
             }
 
-            if (empty($conditions)) {
+            if (! $conditions) {
                 return 'false';
             }
 

…18n/src/Translator/GenericTranslator.php packages/i18n/src/GenericTranslator.phppackages/i18n/src/Translator/GenericTranslator.php renamed to packages/i18n/src/GenericTranslator.php packages/i18n/src/Translator/GenericTranslator.php renamed to packages/i18n/src/GenericTranslator.php

@@ -1,21 +1,20 @@
 <?php
 
-namespace Tempest\Internationalization\Translator;
+namespace Tempest\Internationalization;
 
-use Tempest\Core\ExceptionReporter;
 use Tempest\EventBus\EventBus;
 use Tempest\Internationalization\Catalog\Catalog;
 use Tempest\Internationalization\InternationalizationConfig;
 use Tempest\Internationalization\MessageFormat\Formatter\MessageFormatter;
 use Tempest\Support\Language\Locale;
 
-final class GenericTranslator implements Translator
+final readonly class GenericTranslator implements Translator
 {
     public function __construct(
-        private readonly InternationalizationConfig $config,
-        private readonly Catalog $catalog,
-        private readonly MessageFormatter $formatter,
-        private readonly ?EventBus $eventBus = null,
+        private InternationalizationConfig $config,
+        private Catalog $catalog,
+        private MessageFormatter $formatter,
+        private ?EventBus $eventBus = null,
     ) {}
 
     public function translateForLocale(Locale $locale, string $key, mixed ...$arguments): string

packages/i18n/src/MessageFormat/Formatter/FormattedValue.php

@@ -2,10 +2,10 @@
 
 namespace Tempest\Internationalization\MessageFormat\Formatter;
 
-final class FormattedValue
+final readonly class FormattedValue
 {
     public function __construct(
-        public readonly mixed $value,
-        public readonly string $formatted,
+        public mixed $value,
+        public string $formatted,
     ) {}
 }

packages/i18n/src/MessageFormat/Formatter/MessageFormatter.php

@@ -3,7 +3,6 @@
 namespace Tempest\Internationalization\MessageFormat\Formatter;
 
 use Exception;
-use Tempest\Internationalization\InternationalizationConfig;
 use Tempest\Internationalization\MessageFormat\Parser\Node\ComplexBody\ComplexBody;
 use Tempest\Internationalization\MessageFormat\Parser\Node\ComplexBody\Matcher;
 use Tempest\Internationalization\MessageFormat\Parser\Node\ComplexBody\SimplePatternBody;
@@ -242,7 +241,7 @@ private function evaluateExpression(Expression $expression): FormattedValue
             $variableName = $expression->variable->name->name;
 
             if (! array_key_exists($variableName, $this->variables)) {
-                throw new FormattingException("Variable `$variableName` not found");
+                throw new FormattingException("Variable `{$variableName}` not found");
             }
 
             $value = $this->variables[$variableName];
@@ -304,9 +303,9 @@ private function formatMarkup(Markup $markup): string
         $tag = (string) $markup->identifier;
 
         return match ($markup->type) {
-            MarkupType::OPEN => "<$tag>",
-            MarkupType::CLOSE => "</$tag>",
-            MarkupType::STANDALONE => "<$tag/>",
+            MarkupType::OPEN => "<{$tag}>",
+            MarkupType::CLOSE => "</{$tag}>",
+            MarkupType::STANDALONE => "<{$tag}/>",
             default => '',
         };
     }

packages/i18n/src/MessageFormat/Parser/Node/ComplexBody/Matcher.php

@@ -4,15 +4,15 @@
 
 use Tempest\Internationalization\MessageFormat\Parser\Node\Pattern\Pattern;
 
-final class Matcher implements ComplexBody
+final readonly class Matcher implements ComplexBody
 {
     /**
      * @param Variable[] $selectors
      * @param Variant[] $variants
      */
     public function __construct(
-        public readonly array $selectors,
-        public readonly array $variants,
+        public array $selectors,
+        public array $variants,
     ) {}
 
     public function getPattern(): Pattern

packages/i18n/src/MessageFormat/Parser/Node/ComplexBody/SimplePatternBody.php

@@ -4,10 +4,10 @@
 
 use Tempest\Internationalization\MessageFormat\Parser\Node\Pattern\Pattern;
 
-final class SimplePatternBody implements ComplexBody
+final readonly class SimplePatternBody implements ComplexBody
 {
     public function __construct(
-        public readonly Pattern $pattern,
+        public Pattern $pattern,
     ) {}
 
     public function getPattern(): Pattern

packages/i18n/src/MessageFormat/Parser/Node/ComplexBody/Variant.php

@@ -5,13 +5,13 @@
 use Tempest\Internationalization\MessageFormat\Parser\Node\Node;
 use Tempest\Internationalization\MessageFormat\Parser\Node\Pattern\QuotedPattern;
 
-final class Variant implements Node
+final readonly class Variant implements Node
 {
     /**
      * @param Key[] $keys
      */
     public function __construct(
-        public readonly array $keys,
-        public readonly QuotedPattern $pattern,
+        public array $keys,
+        public QuotedPattern $pattern,
     ) {}
 }

packages/i18n/src/MessageFormat/Parser/Node/Declaration/InputDeclaration.php

@@ -4,9 +4,9 @@
 
 use Tempest\Internationalization\MessageFormat\Parser\Node\Expression\VariableExpression;
 
-final class InputDeclaration implements Declaration
+final readonly class InputDeclaration implements Declaration
 {
     public function __construct(
-        public readonly VariableExpression $expression,
+        public VariableExpression $expression,
     ) {}
 }

packages/i18n/src/MessageFormat/Parser/Node/Declaration/LocalDeclaration.php

@@ -5,10 +5,10 @@
 use Tempest\Internationalization\MessageFormat\Parser\Node\Expression\Expression;
 use Tempest\Internationalization\MessageFormat\Parser\Node\Variable;
 
-final class LocalDeclaration implements Declaration
+final readonly class LocalDeclaration implements Declaration
 {
     public function __construct(
-        public readonly Variable $variable,
-        public readonly Expression $expression,
+        public Variable $variable,
+        public Expression $expression,
     ) {}
 }

packages/i18n/src/MessageFormat/Parser/Node/Expression/Attribute.php

@@ -6,10 +6,10 @@
 use Tempest\Internationalization\MessageFormat\Parser\Node\Literal\Literal;
 use Tempest\Internationalization\MessageFormat\Parser\Node\Node;
 
-final class Attribute implements Node
+final readonly class Attribute implements Node
 {
     public function __construct(
-        public readonly Identifier $identifier,
-        public readonly ?Literal $value,
+        public Identifier $identifier,
+        public ?Literal $value,
     ) {}
 }