feat(database): support for hooked virtual properties (#1586)

Author: brendt

packages/database/src/Builder/ModelInspector.php

@@ -347,7 +347,7 @@ public function getSelectFields(): ImmutableArray
                 continue;
             }
 
-            if ($property->hasAttribute(Virtual::class)) {
+            if ($property->isVirtual() || $property->hasAttribute(Virtual::class)) {
                 continue;
             }
 

packages/database/src/Builder/QueryBuilders/InsertQueryBuilder.php

@@ -398,6 +398,10 @@ private function resolveObjectData(object $model): array
                 continue;
             }
 
+            if ($property->isVirtual()) {
+                continue;
+            }
+
             $propertyName = $property->getName();
 
             if ($property->hasAttribute(Virtual::class)) {

tests/Integration/Database/Builder/IsDatabaseModelTest.php

@@ -435,7 +435,7 @@ public function test_no_result(): void
 
     public function test_create_with_virtual_property(): void
     {
-        $this->migrate(
+        $this->database->migrate(
             CreateMigrationsTable::class,
             CreateATable::class,
             CreateBTable::class,
@@ -451,6 +451,27 @@ public function test_create_with_virtual_property(): void
         $this->assertSame(-$a->id->value, $a->fake);
     }
 
+    public function test_virtual_hooked_property(): void
+    {
+        $this->database->migrate(
+            CreateMigrationsTable::class,
+            CreateModelWithHookedVirtualPropertyTable::class,
+        );
+
+        $a = ModelWithHookedVirtualProperty::create(
+            name: 'a',
+        );
+
+        $this->assertSame('A', $a->hookedName);
+
+        $a = ModelWithHookedVirtualProperty::select()->first();
+        $this->assertSame('A', $a->hookedName);
+
+        $a->name = 'b';
+        $a->save();
+        $this->assertSame('B', $a->hookedName);
+    }
+
     public function test_select_virtual_property(): void
     {
         $this->migrate(
@@ -1047,3 +1068,27 @@ final class BNullableModel
 
     public string $name;
 }
+
+final class CreateModelWithHookedVirtualPropertyTable implements MigratesUp
+{
+    public string $name = '100-create-model-with-hooked-virtual-property';
+
+    public function up(): QueryStatement
+    {
+        return new CreateTableStatement('model_with_hooked_virtual_property')
+            ->primary()
+            ->string('name');
+    }
+}
+
+#[Table('model_with_hooked_virtual_property')]
+final class ModelWithHookedVirtualProperty
+{
+    use IsDatabaseModel;
+
+    public string $name;
+
+    public string $hookedName {
+        get => strtoupper($this->name);
+    }
+}