fix(view): consume dynamic attributes (#644)

Author: brendt

src/Tempest/View/src/Element.php

@@ -16,6 +16,8 @@ public function getAttribute(string $name): string|null;
 
     public function setAttribute(string $name, string $value): self;
 
+    public function consumeAttribute(string $name): string|null;
+
     public function setPrevious(?Element $previous): self;
 
     public function getPrevious(): ?Element;

src/Tempest/View/src/Elements/IsElement.php

@@ -53,6 +53,15 @@ public function setAttribute(string $name, string $value): self
         return $this;
     }
 
+    public function consumeAttribute(string $name): string|null
+    {
+        $value = $this->getAttribute($name);
+
+        $this->unsetAttribute($name);
+
+        return $value;
+    }
+
     public function unsetAttribute(string $name): self
     {
         $name = ltrim($name, ':');

src/Tempest/View/src/Elements/PhpForeachElement.php

@@ -32,10 +32,12 @@ public function setElse(Element $element): self
 
     public function compile(): string
     {
+        $foreachAttribute = $this->wrappingElement->consumeAttribute('foreach');
+
         $compiled = sprintf(
             '<?php foreach (%s): ?>
 %s',
-            $this->wrappingElement->getAttribute('foreach'),
+            $foreachAttribute,
             $this->wrappingElement->compile(),
         );
 
@@ -47,8 +49,9 @@ public function compile(): string
         );
 
         if ($this->else !== null) {
-            $collectionName = str($this->wrappingElement->getAttribute('foreach'))
-                ->match('/^(?<match>.*)\s+as/')['match'];
+            $collectionName = str($foreachAttribute)->match('/^(?<match>.*)\s+as/')['match'];
+
+            $this->else->consumeAttribute('forelse');
 
             $compiled = sprintf(
                 '<?php if(iterator_count(%s)): ?>

src/Tempest/View/src/Elements/PhpIfElement.php

@@ -44,7 +44,7 @@ public function compile(): string
         $compiled = sprintf(
             "<?php if(%s): ?>
                 %s",
-            $this->wrappingElement->getAttribute('if'),
+            $this->wrappingElement->consumeAttribute('if'),
             $this->wrappingElement->compile(),
         );
 
@@ -54,12 +54,14 @@ public function compile(): string
                 <?php elseif(%s): ?>
                 %s",
                 $compiled,
-                $elseif->getAttribute('elseif'),
+                $elseif->consumeAttribute('elseif'),
                 $elseif->compile(),
             );
         }
 
         if ($this->else !== null) {
+            $this->else->consumeAttribute('else');
+
             $compiled = sprintf(
                 "%s
                 <?php else: ?>

tests/Integration/View/TempestViewRendererTest.php

@@ -52,58 +52,58 @@ public function test_if_attribute(): void
         );
 
         $this->assertSame(
-            '<div :if="$this->show">Hello</div>',
+            '<div>Hello</div>',
             $this->render(view('<div :if="$this->show">Hello</div>')->data(show: true)),
         );
     }
 
     public function test_elseif_attribute(): void
     {
         $this->assertSame(
-            '<div :if="$this->a">A</div>',
+            '<div>A</div>',
             $this->render(view('<div :if="$this->a">A</div><div :elseif="$this->b">B</div><div :else>None</div>')->data(a: true, b: true)),
         );
 
         $this->assertSame(
-            '<div :if="$this->a">A</div>',
+            '<div>A</div>',
             $this->render(view('<div :if="$this->a">A</div><div :elseif="$this->b">B</div><div :else>None</div>')->data(a: true, b: false)),
         );
 
         $this->assertSame(
-            '<div :elseif="$this->b">B</div>',
+            '<div>B</div>',
             $this->render(view('<div :if="$this->a">A</div><div :elseif="$this->b">B</div><div :else>None</div>')->data(a: false, b: true)),
         );
 
         $this->assertSame(
-            '<div :else>None</div>',
+            '<div>None</div>',
             $this->render(view('<div :if="$this->a">A</div><div :elseif="$this->b">B</div><div :else>None</div>')->data(a: false, b: false)),
         );
 
         $this->assertSame(
-            '<div :elseif="$this->c">C</div>',
+            '<div>C</div>',
             $this->render(view('<div :if="$this->a">A</div><div :elseif="$this->b">B</div><div :elseif="$this->c">C</div><div :else>None</div>')->data(a: false, b: false, c: true)),
         );
 
         $this->assertSame(
-            '<div :elseif="$this->b">B</div>',
+            '<div>B</div>',
             $this->render(view('<div :if="$this->a">A</div><div :elseif="$this->b">B</div><div :elseif="$this->c">C</div><div :else>None</div>')->data(a: false, b: true, c: true)),
         );
 
         $this->assertSame(
-            '<div :else>None</div>',
+            '<div>None</div>',
             $this->render(view('<div :if="$this->a">A</div><div :elseif="$this->b">B</div><div :elseif="$this->c">C</div><div :else>None</div>')->data(a: false, b: false, c: false)),
         );
     }
 
     public function test_else_attribute(): void
     {
         $this->assertSame(
-            '<div :if="$this->show">True</div>',
+            '<div>True</div>',
             $this->render(view('<div :if="$this->show">True</div><div :else>False</div>')->data(show: true)),
         );
 
         $this->assertSame(
-            '<div :else>False</div>',
+            '<div>False</div>',
             $this->render(view('<div :if="$this->show">True</div><div :else>False</div>')->data(show: false)),
         );
     }
@@ -112,25 +112,49 @@ public function test_foreach_attribute(): void
     {
         $this->assertStringEqualsStringIgnoringLineEndings(
             <<<'HTML'
-            <div :foreach="$this->items as $foo">a</div>
-            <div :foreach="$this->items as $foo">b</div>
+            <div>a</div>
+            <div>b</div>
             HTML,
             $this->render(view('<div :foreach="$this->items as $foo">{{ $foo }}</div>')->data(items: ['a', 'b'])),
         );
     }
 
+    public function test_foreach_consumes_attribute(): void
+    {
+        $html = $this->render(view(
+            <<<'HTML'
+        <x-base>
+            <table>
+                <tr :foreach="$items as $item">
+                    <td>{{ $item }}</td>
+                </tr>
+            </table>
+        </x-base>
+        HTML,
+        )->data(items: ['a', 'b']));
+
+        $this->assertStringContainsStringIgnoringLineEndings(
+            <<<'HTML'
+        <html lang="en"><head><title>Home</title></head><body><table><tr><td>a</td></tr>
+        <tr><td>b</td></tr>
+        </table></body></html>
+        HTML,
+            $html
+        );
+    }
+
     public function test_forelse_attribute(): void
     {
         $this->assertSame(
             <<<'HTML'
-            <div :forelse>Empty</div>
+            <div>Empty</div>
             HTML,
             $this->render(view('<div :foreach="$this->items as $foo">{{ $foo }}</div><div :forelse>Empty</div>')->data(items: [])),
         );
 
         $this->assertSame(
             <<<'HTML'
-            <div :foreach="$this->items as $foo">a</div>
+            <div>a</div>
             HTML,
             $this->render(view('<div :foreach="$this->items as $foo">{{ $foo }}</div><div :forelse>Empty</div>')->data(items: ['a'])),
         );