fix: support not having a Redis connection in insights

Author: innocenzi

packages/kv-store/src/Redis/PhpRedisClient.php

@@ -22,6 +22,10 @@ public function __construct(
 
     public function connect(): void
     {
+        if ($this->client->isConnected()) {
+            return;
+        }
+
         if ($this->config->persistent) {
             $this->client->pconnect(
                 host: $this->config->unixSocketPath ?? $this->config->host ?? '127.0.0.1',

packages/kv-store/src/Redis/PredisClient.php

@@ -19,6 +19,10 @@ public function __construct(
 
     public function connect(): void
     {
+        if ($this->client->isConnected()) {
+            return;
+        }
+
         $this->client->connect();
     }
 

packages/kv-store/src/Redis/RedisInsightsProvider.php

@@ -18,15 +18,22 @@ public function __construct(
     public function getInsights(): array
     {
         $client = $this->redis->getClient();
-        $version = Regex\get_match($this->redis->command('info', 'server'), '/redis_version:(?<version>[0-9.]+)/', match: 'version');
 
-        return [
-            'Engine' => match (get_class($client)) {
-                \Redis::class => 'Redis extension',
-                Predis\Client::class => 'Predis',
-                default => new Insight('None', Insight::WARNING),
-            },
-            'Version' => $version ?: new Insight('Unknown', Insight::WARNING),
-        ];
+        try {
+            $version = Regex\get_match($this->redis->command('info', 'server'), '/redis_version:(?<version>[0-9.]+)/', match: 'version');
+
+            return [
+                'Engine' => match (get_class($client)) {
+                    \Redis::class => 'Redis extension',
+                    Predis\Client::class => 'Predis',
+                    default => new Insight('None', Insight::WARNING),
+                },
+                'Version' => $version ?: new Insight('Unknown', Insight::WARNING),
+            ];
+        } catch (\Throwable) {
+            return [
+                'Engine' => new Insight('Disconnected', Insight::ERROR),
+            ];
+        }
     }
 }