test: ensure session cookie properties

Author: innocenzi

packages/http/src/Session/Resolvers/CookieSessionIdResolver.php

@@ -27,18 +27,18 @@ public function __construct(
 
     public function resolve(): SessionId
     {
-        $sessionId = str($this->appConfig->name ?? 'tempest')
+        $sessionKey = str($this->appConfig->name ?? 'tempest')
             ->snake()
             ->append('_session_id')
             ->toString();
 
-        $id = $this->cookies->get($sessionId)->value ?? null;
+        $id = $this->cookies->get($sessionKey)->value ?? null;
 
         if (! $id) {
             $id = (string) Uuid::v4();
 
             $this->cookies->add(new Cookie(
-                key: $sessionId,
+                key: $sessionKey,
                 value: $id,
                 path: '/',
                 secure: true,

packages/http/src/Session/Resolvers/HeaderSessionIdResolver.php

@@ -19,13 +19,13 @@ public function __construct(
 
     public function resolve(): SessionId
     {
-        $sessionId = str($this->appConfig->name ?? 'tempest')
+        $sessionKey = str($this->appConfig->name ?? 'tempest')
             ->snake()
             ->append('_session_id')
             ->toString();
 
         return new SessionId(
-            id: $this->request->headers[$sessionId] ?? Uuid::v4()->toString(),
+            id: $this->request->headers[$sessionKey] ?? Uuid::v4()->toString(),
         );
     }
 }

tests/Integration/Http/CookieSessionIdResolverTest.php

@@ -0,0 +1,39 @@
+<?php
+
+namespace Tests\Tempest\Integration\Http;
+
+use Tempest\Core\AppConfig;
+use Tempest\DateTime\DateTime;
+use Tempest\Http\Cookie\Cookie;
+use Tempest\Http\Cookie\CookieManager;
+use Tempest\Http\Cookie\SameSite;
+use Tempest\Http\Session\Resolvers\CookieSessionIdResolver;
+use Tests\Tempest\Integration\FrameworkIntegrationTestCase;
+
+final class CookieSessionIdResolverTest extends FrameworkIntegrationTestCase
+{
+    public function test_sets_cookie(): void
+    {
+        $cookies = $this->container->get(CookieManager::class);
+        $resolver = $this->container->get(CookieSessionIdResolver::class);
+        $resolver->resolve();
+
+        $this->assertInstanceOf(Cookie::class, $cookie = $cookies->get('tempest_session_id'));
+        $this->assertTrue($cookie->expiresAt->after(DateTime::now()->plusHours(2)->minusSecond()));
+        $this->assertSame('/', $cookie->path);
+        $this->assertTrue($cookie->secure);
+        $this->assertTrue($cookie->httpOnly);
+        $this->assertSame(SameSite::LAX, $cookie->sameSite);
+    }
+
+    public function test_cookie_name(): void
+    {
+        $this->container->get(AppConfig::class)->name = 'Tempest Cloud';
+
+        $cookies = $this->container->get(CookieManager::class);
+        $resolver = $this->container->get(CookieSessionIdResolver::class);
+        $resolver->resolve();
+
+        $this->assertInstanceOf(Cookie::class, $cookies->get('tempest_cloud_session_id'));
+    }
+}